Fix overlooked rename of ID to id in synthDriverHandler.LanguageInfo#9587
Merged
Conversation
Contributor
|
hi.
newfon synthesizer is a driver which is using LanguageInfo.
i cannot test it because my build environment is not ready for building nvda.
if there would be any of them, try build or merging pr, i would be able to test
…On 5/18/19, Leonard de Ruijter ***@***.***> wrote:
### Link to issue number:
#7452 (comment)
### Summary of the issue:
When renaming ID to id on driverHandler.StringParameterInfo, one case was
missed for LanguageInfo.
### Description of how this pull request fixes the issue:
Fixed as suggested by @beqabeqa473
### Testing performed:
@beqabeqa473: With what driver did you encounter this? Would you be able to
test this?
### Known issues with pull request:
None
### Change log entry:
None
You can view, comment on, or merge this pull request online at:
#9587
-- Commit Summary --
* Fix overlooked rane of ID to id in synthDriverHandler.LanguageInfo
-- File Changes --
M source/synthDriverHandler.py (2)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/9587.patch
https://github.com/nvaccess/nvda/pull/9587.diff
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#9587
--
with best regards beqa
|
Contributor
|
hi |
Contributor
|
feerrenrut
approved these changes
May 20, 2019
Contributor
|
ok, it fixed a problem.
…On 5/20/19, Reef Turner ***@***.***> wrote:
Merged #9587 into master.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#9587 (comment)
--
with best regards beqa
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#7452 (comment)
Summary of the issue:
When renaming ID to id on driverHandler.StringParameterInfo, one case was missed for LanguageInfo.
Description of how this pull request fixes the issue:
Fixed as suggested by @beqabeqa473
Testing performed:
@beqabeqa473: With what driver did you encounter this? Would you be able to test this?
Known issues with pull request:
None
Change log entry:
None