Excel cell range text should be translated.#9470
Closed
nishimotz wants to merge 1 commit into
Closed
Conversation
michaelDCurran
approved these changes
Apr 9, 2019
Collaborator
|
Should this be filed against RC?
… Op 9 apr. 2019 om 06:34 heeft Michael Curran ***@***.***> het volgende geschreven:
@michaelDCurran approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
I can't seem to change the base from beta to rc. It is possible there might be conflicts. @nishimotz might need to rebase or fix the conflicts manually and push here again and change the base branch. |
nishimotz
added a commit
to nishimotz/nvda
that referenced
this pull request
Apr 9, 2019
Contributor
Author
|
I have created another PR against rc as #9471. |
michaelDCurran
pushed a commit
that referenced
this pull request
Apr 9, 2019
Contributor
|
Shouldn't this one be closed, and RC merged to master? |
Contributor
|
hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
none
Summary of the issue:
NVDA does not use the localized message when reporting the position of merged cells in Microsoft Excel.
Description of how this pull request fixes the issue:
This is against the beta branch, however,
it reuses existing message which already has the translation,
so the additional translation is not necessary.
Testing performed:
Office 365 Excel version 1903
NVDA 2019.1.1rc1
Windows 10 version 1809 Japanese
Known issues with pull request:
Change log entry:
In Microsoft Excel, NVDA uses the localized message when reporting the location of merged cells again.
Section: Bug fixes