Reducing SynthSettingsRing volume step#9469
Conversation
josephsl
left a comment
There was a problem hiding this comment.
Hi,
Is this guaranteed to work across synthesizers i.e. are there synthesizers that won't accept volume change increments other than 10 percent? Other than that and editing copyright header (mostly changing the copyright year), I'd say it is ready to go.
|
Hello @josephsl, It would be very surprizing if some synthesizers don't support such a basic operation. Can anyone shed light on this please? What's wrong with the copyright header by the way? |
|
I found how to install add-ons on a source version of NVDA while investigating another issue, I updated the PR description accordingly. |
feerrenrut
left a comment
There was a problem hiding this comment.
Overall this looks fine. Thanks for your contribution!
LeonarddeR
left a comment
There was a problem hiding this comment.
You might as well want to update contributors.txt and add your name.
Synthesizer volume is now increased and decreased by 5 instead of 10 when using the settings ring. (Issue #6754)
Link to issue number:
Fixes #6754.
Summary of the issue:
When changing synth volume setting using the settings ring, the value is increased and decreased by 10, which is too much for some users.
Description of how this pull request fixes the issue:
As suggested in #6754, the step has been decreased to 5, which is more acceptable.
Testing performed:
Increased and decreased synth volume using the settings ring and made sure that the value was actually used by the current synth. Tested with the following synthesizers:
Known issues with pull request:
None
Change log entry:
Section: Changes