Upgraded comtypes to 1.1.7#9441
Conversation
|
P.S: I'm posting this mainly to test binary builds from the build server. Cheers, |
|
Do you have any guess as to what exactly changed to give the better performance? I don't see anything too interesting in their changelog... |
|
Here is a signed try build, which really helps in testing these things. |
|
We have:
I don't think that's related. |
LeonarddeR
left a comment
There was a problem hiding this comment.
It looks like I can't reproduce the issue I had that was caused by enthought/comtypes@98f6a42, so that's good.
Could you please update the readme to refer to comtypes 1.1.7?
|
As readme is now updated could you add #8522 to the list which this pr closes @francipvb ? |
|
Hello, I have addressed the changes you requested. @michaelDCurran wrote
About performance comment on the issue, I did some testing before posting this PR and I saw that the performance improvement is a side effect of another change, but I was unable to determine what is the cause, there are no changes on UIAHandler's code nor UIA objects since release 2019.1 (python part). Well, perhaps I didn't found them. I think that this is interesting for addon developers:
Cheers, |
Just to make sure, are you saying that Comtypes 1.1.7 does not affect performance? |
|
Hello, I ran two profiling sessions and I got some results. In fact, there is no difference in the performance, so I don't know where is the change that caused this. For completeness, here are the profile session files. Cheers, |
|
Ah... it looks like in commit 92d8487 the readme file has been changed causing a conflict here. I assume line endings have been changed. |
|
I've merged master and pushed the result. |
|
Hi,
Will this be merged to treshold?
|
|
For now it's been merged to master. The threshold branch will be updated from master occasionally. Why do you ask? |
|
I ask, as i’ve switched to it, and I am wanting to help as a translator and as a tester, especially when testing braille in py3.
|
|
I expect the threshold branch to be quite unstable initially, we will likely be quite aware of this. You are welcome to continue using it, however, please wait until we start requesting testers and feedback before creating new issues for it. |
Link to issue number:
Closes #9440, #8522
Summary of the issue:
This PR is mainly to improve UIAutomation support.
I use visual studio regularly and it is a particularly heavy application. It runs background tasks and these impacts the user interface.
However, I upgraded comtypes locally to do some testing and I saw some results regarding performance.
Description of how this pull request fixes the issue:
This upgrades from enthought/comtypes@edbaf3b to enthought/comtypes@1d3d38b
Testing performed:
Tested NVDA running from source code against Visual Studio 2017 and 2019. Got performance improvements with both of versions.
Known issues with pull request:
None known.
Change log entry:
Added by @LeonarddeR