Fixing browse mode not reporting the whole content of a form field if it's not an editable text#9401
Merged
michaelDCurran merged 4 commits intoMar 28, 2019
Conversation
…at is not an editable text.
|
@DataTriny: What do you think about the HTML5 tags |
Contributor
Author
|
@DrSooom The problem with |
michaelDCurran
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9388
Summary of the issue:
When navigating through form fields using browse mode's quick navigation, NVDA only reports the first line even if we are dealing with elements that should not be splitted apart such as buttons.
Description of how this pull request fixes the issue:
Inside
TextInfoQuickNavItem.report()if we are dealing with aformField, examine its real control type to determine whether we should report the whole content.When initializing the quick navigation gesture for form fields, don't specify anymore that we want to only read the first line.
Testing performed:
Navigated inside an HTML page containing a form with various elements with long texts, made sure that those texts were shortened only for editable texts.
Known issues with pull request:
None
Change log entry:
Section: Bug fixes