• PR introduces Flake8 errors
• Build (for testing PR)

See test results for failed build of commit 5a54124e61

I don't think point 2 under known issues is a problem as far as I can tell. However, I am quite concerned about point 1 and the possible mis-understanding by users. Is having this pr really worth that? Is this pr created as there is a great need by users to no longer hear the word "graphic" because it happens a lot... or is this created more for completeness as graphics was one of the only ones we didn't allow disabling?

What other screen readers are doing in this case?

Is this pr created as there is a great need by users to no longer hear the word "graphic" because it happens a lot... or is this created more for completeness as graphics was one of the only ones we didn't allow disabling?

My initial attempt for this pr was one of my first attempts to contribute to NVDA< so that's a long time ago.

#4837 was opened by @surfer0627, so may be he could elaborate. One of the use cases though is in applications where graphic is reported for every line erroneously. I've seen this in Adobe Reader as well. The behavior, namely that only the word graphic is ommitted is in line with the other controls that disable reporting of headings, links, etc.

I can provide you tomorrow with a pdf file for example, where there are hundreeds of pages and the thext is actually embeded in a graphic, so NVDA reads "graphic on every line. If you want to read that document, you will get really frustrated because on some lines NVDA reports "grpahic" like multiple times before reporting the actual text on the line.
I saw this behavior very often in pdf documents. I asume they are using IAccessible2 and the virtual buffer like in any browser, so this would apply here as well.

Sorry to comment a bit lately on this PR...

Would it be more suitable to use a ternary option, e.g. with a combo-box as done for the Line indentation reporting option? The 3 options in this combo-box would be:

• off
• alternative description only
• "Graphic" word and alternative description
  For this last option, I did not find a good text, please modify it.

Indeed, I have had the need of each option at one time or another.

• Option 1 to read a newsletter with a lot of graphics that are only images, logos, etc. and where the ALT text is full of long garbage.
• Option 2 to read some PDF's as described by @Adriani90.
• Option 3 to read an unknown document before maybe switching to option 1 or 2.

Note that if this ternary option is validated, this would be an issue for #10448, see my comment there. IMO a ternary option with a single 3-state toggle script is more convenient than two options (announce word "Graphic" dand announce ALT text) and two separated toggle scripts.

Conflicts fixed. Also reverted an accidental line removal in the user guide.

did all your tests involve both braille and speech?

Good point. I realised I didn't test the case where the graphics content was set in content on the control field. Therefore the exception in speech made to that wasn't applied to braille. It now is, and I tested it in Word.