Fix ValueError on update#9027
Merged
Merged
Conversation
|
Could I just point you at a post I just made in the dev list on problems
with add on updates and polling for nvda updates at the same time?
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
-----
|
Collaborator
Author
|
Add-on updates are performed by an add-on itself. Therefore we can't
take these issues into account at the moment. Cc @josephsl.
|
Contributor
|
Hi, yes, so add-on updating issue is separate from this problem. See #3208 for updates and such. Thanks.
From: Leonard de Ruijter <notifications@github.com>
Sent: Friday, December 7, 2018 3:37 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Fix ValueError on update (#9027)
Add-on updates are performed by an add-on itself. Therefore we can't
take these issues into account at the moment. Cc @josephsl.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#9027 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkL6kLcXXTY-KPHJZoi-ncvrh4ZkCks5u2lLGgaJpZM4ZIQH4> .
|
michaelDCurran
approved these changes
Dec 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9026
Summary of the issue:
When updating NVDA, a ValueError was raised when NVDA was unable to create a version tuple from a snapshot build.
Description of how this pull request fixes the issue:
The version tuple is now build from the FIleVersion string embedded in the executable. It is also evaluated before the succeeded download dialog. Whenever the fileVersion attribute is missing (i.e. in older builds), NVDA falls back to the version string. If that fails, the caused traceback is properly handled as were it a failed download.
Testing performed:
From source, set versionInfo.updateVersionType and performed an update using the python colse. Also postponed that update and retriggered the pending installation message, all without errors.
Known issues with pull request:
This relies on file version information embedded in the file. It would help if the server would also fetch the file version information and embed that in the update info. That would also help in evaluating the incompatible add-ons before (not after) downloading the update.
Change log entry:
None needed.