change order of informations presented by CTRL+NVDA+f1, to make changeable info presented first.#8927
Conversation
… info first. fix for nvaccess#7338
|
I think this change itself is minor, and as you mentioned the command isn't mentioned in the user guide. However, there is no seperator between your two messages, be it a comma, a similar character or the word "and". This results in strings like:
with the information running together. |
… the first message.
|
@jscholes Thanks for your commends. I assumed, that the space at the beginning of the second message would be sufficient, but adding a dot after the first looks like a good solution. |
|
Now while we're at it, I think I prefer swapping the order as well. First report the app module, than the executable name. This makes it more intuitive to hear whether a specific appmodule is loaded for an app. |
|
It'd be nice to have this reviewed. |
I'm looking at it now. In the future, please use the "request review" button. Though saying that, do you have access to it? |
|
No i don't as per this commend in the GitHub documentation
|
|
Ah, I see. My apologies. |
This comment has been minimized.
This comment has been minimized.
|
@feerrenrut I believe I have addressed your commend. |
|
There should still be a change log entry. I will add something along the lines of: changes for developers |
Link to issue number:
Fixes #7338
Summary of the issue:
When pressing CTRL+NVDA+F1 the order of information's is not optimal.
Description of how this pull request fixes the issue:
The changeable parts i.e. application name, and app module name are now presented first.
Testing performed:
Tested, that script still present the same info, but in the different order.
Known issues with pull request:
None
Change log entry:
This command isn't even included in the user guide, so i believe, that Change log entry isn't nesesary.