Change shortcut for Filter by field in the elements list from ALT+E to ALT+Y to avoid conflicts in MSWord.#8842
Merged
Merged
Conversation
…o ALT+Y to avoid conflicts. Fix for nvaccess#8728
LeonarddeR
approved these changes
Oct 15, 2018
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
As long as we agree that this will be the ever last change is to this shortcut ;) I"m ok with this.
Contributor
|
What is the current state of this PR? |
Contributor
Author
|
It was approved by @LeonarddeR but after that nothing. It might be a good idea to have non NV Access collaborators request a review from one of the mail developers after approval. |
Collaborator
|
cc: @michaelDCurran |
Contributor
|
Can you update the description to explain how you chose |
Contributor
|
This will have no effect on some locales.
Croatian, polish and serbian, so this only changes for english
|
Contributor
Author
|
@feerrenrut done. |
Contributor
Author
|
@zstanecic wrote:
Well it is translator responsibility to set shortcut for languages other than English. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8728
Summary of the issue:
When browse mode in Microsoft Word was used it was not possible to select errors in the elements list due to shortcut key conflicting with filter by field.
Description of how this pull request fixes the issue:
The shortcut key is now changed to ALT+Y to fix this and hopefully all future conflicts.
Y seems to be reasonable because there is no control starting with Y, and it is only letter include in 'filter by' which isn't used as a quick nav key.
Testing performed:
Tested, that the shortcut is indeed changed.
Known issues with pull request:
None
Change log entry:
The hotkey for the filter field in the elements list in browse mode has changed from alt+e to alt+y.
Section: Changes