Update to pyserial 3.4#8815
Conversation
This comment has been minimized.
This comment has been minimized.
| self._setTimeout(None) | ||
| self.inWaiting = self._ser.inWaiting | ||
| super(Serial, self).__init__(self._ser.hComPort, onReceive) | ||
| super(Serial, self).__init__(self._ser._port_handle, onReceive) |
There was a problem hiding this comment.
This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do.
There was a problem hiding this comment.
I did an extra check, but there doesn't seem to be one.
|
This has the potential to break a lot of add-ons that bundle braille display drivers... and yes, there are a lot of them in the wild. |
You'll probably know more display drivers than I do. To clarify, the only backwards incompatible change is Serial.hComPort to Serial._port_handle, and I don't think that this is used directly by any display driver. For the other changes, the former properties are deprecated in favour of the latter, but the original properties are still available, including the inWaiting function.
This certainly makes sense. |
|
I removed the blocked label as #8006 is merged. |
|
@feerrenrut: similar to your reasoning in #8647, I can't think of any braille display driver that will suffer from the changes in this pr, though @michaelDCurran noted that there are many display drivers in the wild. Add-on versioning is there now, though. |
|
Just for your info, I just discovered that this update is mandatory in order for py2exe to be able to create an NVDA distribution. |
The version number for threshold is currently unknown, I have added a new section at the start of this file as a place holder for this version number. Merges from master with modifications to this file should not be too hard, the changes from master should always come after the changes on the threshold branch. Because they are in different parts of the file there should be very few conflicts.
Link to issue number:
None. However, there is some discussion in #6035
Summary of the issue:
We've been on an old version of pyserial for some time now. Currently, pyserial is at version 3.4. Most notably, this version includes some API changes, however there is still backwards compatibility for almost all of them. Though there is not very much information about Python 3 support of older versions, this version should ensure that full and up to date Python 3 support is covered.
Description of how this pull request fixes the issue:
Testing performed:
Tested auto and manual detection of a Handy Tech Modular Evolution. more testing would be appreciated, especially with regard to the papenmeier driver. I don't expect much trouble, though.
Known issues with pull request:
None
Change log entry: