Emojis: build data for Vietnamese and Chinese variants.#8803
Merged
Conversation
Contributor
|
The build has been tested, and the cldr.dic file for zh_CN is identical to the zh.xml file entry for the annotationsDerived directory. |
LeonarddeR
approved these changes
Sep 29, 2018
Contributor
Author
|
Hi, can you confirm that this is indeed the Simplified Chinese version? If so, then I’m done with this one, otherwise we need to talk to others. Thanks.
From: 星空 <notifications@github.com>
Sent: Friday, September 28, 2018 8:21 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Emojis: build data for Vietnamese and Chinese variants. (#8803)
The build has been tested, and the cldr.dic file for zh_CN is identical to the zh.xml file entry for the annotationsDerived directory.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8803 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkIoTEnIIO3iGvMgwBlALiTMCttp7ks5ufucagaJpZM4XASBX> .
|
Contributor
|
Yes, this is the simplified Chinese emoticon dictionary. |
michaelDCurran
approved these changes
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8799
Summary of the issue:
Emoji data are missing for Vietnamese and Chinese variants.
Description of how this pull request fixes the issue:
CLDR sconscript has been edited to add emoji XML files for Vietnamese (vi) and Chinese (zh) variants.
Testing performed:
Compiled and used nVDA in those languages.
Known issues with pull request:
None
Change log entry:
None