Skip to content

Update liblouis to version 3.7, add new chinese tables#8710

Merged
michaelDCurran merged 4 commits into
nvaccess:masterfrom
BabbageCom:liblouis3.7
Sep 4, 2018
Merged

Update liblouis to version 3.7, add new chinese tables#8710
michaelDCurran merged 4 commits into
nvaccess:masterfrom
BabbageCom:liblouis3.7

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Closes #5553
Closes #8697

Summary of the issue:

Liblouis 3.7 has been released today.

Description of how this pull request fixes the issue:

  1. Updates liblouis to version 3.7

  2. Add new Mandarin Chinese tables

  3. In trying to make the NVDA build resemble upstream as much as possible, metadata.c is now also included in the build process. Also, Liblouis is no longer compiled with the UNICODE flag. There are two reasons for this:

    1. Upstream doesn't define UNICODE either.
    2. It causes signed/unsigned missmatch warnings when compiling with UCS-4 support. Though UCS-4 is not yet the default. I will publish try builds with this functionality whenever this pr is merged. Also, metadata.c doesn't build without warnings when UNICODE is defined.

Testing performed:

Created try build, loaded the two new Chinese tables.

Known issues with pull request:

None

Change log entry:

@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

A try build is here.

@zstanecic

zstanecic commented Sep 3, 2018 via email

Copy link
Copy Markdown
Contributor

@michaelDCurran michaelDCurran merged commit d1ba63a into nvaccess:master Sep 4, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Liblouis 3.7 Two new braille tables in simplified Chinese.

4 participants