Add command line parameter for silent installations to disable NVDA at the logon screen and enhance portable-path command line behavior by LeonarddeR · Pull Request #8623 · nvaccess/nvda

LeonarddeR · 2018-08-13T09:06:31Z

Link to issue number:

Fixes #8574

Summary of the issue:

In the current situation, it is not possible to specify the start at logon behaviour from the command line. This issue is relevant for system administrators who want to install NVDA silently on a multi user system.
When starting NVDA with the --portable-path command line parameter and creating a portable copy from the GUI, the provided portable path isn't shown in the gui as one might expect.

Description of how this pull request fixes the issue:

Added a --enable-start-on-logon command line parameter. It should be specified as --enable-start-on-logon=True or --enable-start-on-logon=False, just --enable-start-on-logon will show an error message. Alternative supported values are yes/no, on/off, 1/0 (i.e. this option behaves as configobj boolean). NVDA's behaviour is to default this to True
When the --portable-path parameter is provided at NVDA start, the provided path is now pre-filled in in the portable copy creation dialog.

Testing performed:

Ran try build.

Just the launcher: in the installation dialog, use NVDA on logon was enabled.
launcher with --enable-start-on-logon=True: in the installation dialog, use NVDA on logon was enabled.
launcher with --enable-start-on-logon=False: in the installation dialog, use NVDA on logon was disabled.
launcher with --install-silent and --enable-start-on-logon=False. IN the copy of NVDA that ran after installation, start on logon was disabled in the general settings.
Launcher with --portable-path: the provided portable path showed up in the create portable copy dialog.

Known issues with pull request:

None

Change log entry:

New features
- Added the --disable-start-on-logon command line parameter to allow silent installations of NVDA that don't run at the logon screen by default. (Add a command line parameter to disable start at logon screen for silent installations #8574)
Changes
- When NVDA is started with the --portable-path command line parameter, the provided path is automatically filled in when trying to create a portable copy of NVDA using the NVDA menu. (Add command line parameter for silent installations to disable NVDA at the logon screen and enhance portable-path command line behavior #8623)

… path in the gui if applicable

feerrenrut · 2018-08-20T02:11:41Z

Hate to question this further at this stage. But, I'm wondering if it might be more future proof to have this option as --enable-start-on-logon [true|false].

This means that the command line option remains useful if we ever change the default. It also allows people to be specific about their expectations on the command line (whether that is to enable or disable), rather than relying on the implicit default behaviour.

LeonarddeR · 2018-08-20T06:07:40Z

I'm afraid having an enable command line parameter is problematic, as I think argparse is able to store either True or False, not True, False or None. In my opinion, enable-start-on-logon only makes sense if it really enables start on logon in every case. This is certainly something to explore though.

feerrenrut · 2018-08-21T03:36:48Z

If we are able to be concrete about it and say the default is enable-start-on-logon=True then I think it would be my preference, but first we have to identify what variations in behaviour exist at the moment (which I think is what you were getting at with your last comment).

Otherwise, it looks like you can use a combination of default and type to ensure a boolean arg with a default of None:

>>> import argparse
>>> p = argparse.ArgumentParser()
>>> p.add_argument('--foo', default=None, type=bool)
_StoreAction(option_strings=['--foo'], dest='foo', nargs=None, const=None, default=None, type=<type 'bool'>, choices=None, help=None, metavar=None)
>>> p.parse_args(['--foo', 'True'])
Namespace(foo=True)
>>> p.parse_args(['--foo', 'False'])
Namespace(foo=True)
>>> p.parse_args([])
Namespace(foo=None)
>>> p.parse_args(['--foo', '"hello"'])
Namespace(foo=True)
>>> p.parse_args(['--foo', '0'])
Namespace(foo=True)
>>> p.parse_args(['--foo', '1'])
Namespace(foo=True)
>>> p.parse_args(['--foo', 0])
Namespace(foo=False)

Note that this appears to rely on casting the argument value to bool. But I don't think this should be a problem.

LeonarddeR · 2018-08-21T05:43:51Z

@feerrenrut commented on 21 aug. 2018 05:36 CEST:

Otherwise, it looks like you can use a combination of default and type to ensure a boolean arg with a default of None:

This works when throwing False or 0 at parse-args, but when providing 0 or False at the command line, it looks like it will still use the bool value of the string "0" or "False".

bool("False")
True

We can probably fix this with an easy function though:

def stringToBool(s):
    return s.lower() not in ("0", "false", "off")

Then, use stringToBool as the type.

…quires either True/False, Yes/No, On/Off, 1/0 as its value

derekriemer · 2018-08-26T06:28:56Z

If you make it optional, with a default of None what happens?

LeonarddeR · 2018-08-27T06:11:01Z

@derekriemer commented on 26 aug. 2018 08:28 CEST:

If you make it optional, with a default of None what happens?

I updated the description of the pr to reflect your question.

LeonarddeR · 2018-12-05T14:40:40Z

@feerrenrut: I think I've addressed your concerns. A user can now provide enable-start-on-logon=True or --enable-start-on-logon=False to forcefully enable or disable starting at the logon screen when installing or updating. The default for --enable-start-on-logon is None, in which case the old behaviour applies (i.e. if updating, use the current value, else True)

feerrenrut

Sorry, I forgot all about this PR. I'm generally happy with this, but have a suggestion to improve the user guide.

… conflicts

Co-Authored-By: leonardder <leonardder@users.noreply.github.com>

…r Account Control

LeonarddeR · 2018-12-13T12:42:34Z

Done, thanks for this. I added an additional sentence in the start at logon section.

Add --disable-start-on-logon command line parameter and show portable…

0cd9dfc

… path in the gui if applicable

LeonarddeR requested a review from feerrenrut August 15, 2018 08:55

Partial commit

f2c9ffd

Rename --disable-start-on-logon to --enable-start-on-logon. It now re…

ff03ba7

…quires either True/False, Yes/No, On/Off, 1/0 as its value

LeonarddeR mentioned this pull request Sep 8, 2018

Start NVDA after sign in option is sometimes not preserved when updating #8720

Open

feerrenrut suggested changes Dec 13, 2018

View reviewed changes

Comment thread user_docs/en/userGuide.t2t Outdated

Leonard de Ruijter and others added 3 commits December 13, 2018 13:35

Merge remote-tracking branch 'origin/master' into i8574, fixing merge…

3dfe4a8

… conflicts

Update user_docs/en/userGuide.t2t

d4e28aa

Co-Authored-By: leonardder <leonardder@users.noreply.github.com>

Review action in userGuide. Also, instead of UAC control, mention Use…

5690b32

…r Account Control

feerrenrut approved these changes Dec 13, 2018

View reviewed changes

Update changes file for PR #8263

1b9c0e8

feerrenrut merged commit 7274f9b into nvaccess:master Dec 13, 2018

nvaccessAuto added this to the 2018.4 milestone Dec 13, 2018

lukaszgo1 mentioned this pull request Jan 13, 2019

Add command line option to disable "Use NVDA on the Windows logon screen" #7298

Closed

LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add command line parameter for silent installations to disable NVDA at the logon screen and enhance portable-path command line behavior#8623

Add command line parameter for silent installations to disable NVDA at the logon screen and enhance portable-path command line behavior#8623
feerrenrut merged 7 commits into
nvaccess:masterfrom
BabbageCom:i8574

LeonarddeR commented Aug 13, 2018 •

edited by feerrenrut

Loading

Uh oh!

feerrenrut commented Aug 20, 2018

Uh oh!

LeonarddeR commented Aug 20, 2018 via email

Uh oh!

feerrenrut commented Aug 21, 2018

Uh oh!

LeonarddeR commented Aug 21, 2018

Uh oh!

derekriemer commented Aug 26, 2018

Uh oh!

LeonarddeR commented Aug 27, 2018

Uh oh!

LeonarddeR commented Dec 5, 2018

Uh oh!

feerrenrut left a comment

Uh oh!

Uh oh!

LeonarddeR commented Dec 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

LeonarddeR commented Aug 13, 2018 • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Change log entry:

Uh oh!

feerrenrut commented Aug 20, 2018

Uh oh!

LeonarddeR commented Aug 20, 2018 via email

Uh oh!

feerrenrut commented Aug 21, 2018

Uh oh!

LeonarddeR commented Aug 21, 2018

Uh oh!

derekriemer commented Aug 26, 2018

Uh oh!

LeonarddeR commented Aug 27, 2018

Uh oh!

LeonarddeR commented Dec 5, 2018

Uh oh!

feerrenrut left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LeonarddeR commented Dec 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LeonarddeR commented Aug 13, 2018 •

edited by feerrenrut

Loading