Skip to content

Display log viewer even there's no dev info for navigator object#8614

Merged
feerrenrut merged 1 commit into
nvaccess:masterfrom
AAClause:i8613
May 10, 2019
Merged

Display log viewer even there's no dev info for navigator object#8614
feerrenrut merged 1 commit into
nvaccess:masterfrom
AAClause:i8613

Conversation

@AAClause

@AAClause AAClause commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #8613

Summary of the issue:

When there's no info developer for current navigator object, the log viewer cannot be displayed.

Description of how this pull request fixes the issue:

This PR just adds a condition. If there's no dev info, a appropriate message is logged and the log is displayed.

Testing performed:

Tested with a test build and through a small global plugin under my installed version.

Known issues with pull request:

None

Change log entry:

Bug fixes

@feerrenrut

Copy link
Copy Markdown
Contributor

While we went through a period of asking for the changes file to be updated on the feature branch, it led to too many conflicts. I have pulled out the change log line and put it in the description. Unfortunately the web editor has changed all the line endings for the changes file. I'll push a change to fix this.

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Andre9642

@feerrenrut feerrenrut merged commit cae0dd4 into nvaccess:master May 10, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone May 10, 2019
feerrenrut added a commit that referenced this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log viewer doesn't display if there's no Dev info for navigator object

4 participants