Find dialog: NVDA will no longer appear to do nothing when trying to find something while NVDA's About dialog is open#8595
Merged
Conversation
Contributor
Author
|
Hi, I'm wondering: should this go to 2018.3? If yes, I'll add a bug fix entry provided that it should indeed make the cut for 2018.3, otherwise I'll rebase this work on master. Thanks. |
Contributor
|
Should this PR go into 2018.4? |
Contributor
Author
|
Hi, ideally yes. Thanks.
From: Ethan Holliger <notifications@github.com>
Sent: Wednesday, October 24, 2018 8:04 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Find dialog: NVDA will no longer appear to do nothing when trying to find something while NVDA's About dialog is open (#8595)
Should this PR go into 2018.4?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8595 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkKwY8VWSfABYzioOvckPQgAxrg2Tks5uoSoxgaJpZM4Vvmdt> .
|
Member
|
Apologies: I keep missing this pr. |
Contributor
Author
|
Hi, Shall be done in a few minutes. Thanks for bringing this up. |
…find text while NVDA's about dialog is opened. Re nvaccess#8566. wxPython 4: somehow, Find dialog (Control+NVDA+F) doesn't work if NVDA's About dialog is opened. Mitigate this by giving this dialog the same treattment as elements list - creating a run callback.
Contributor
Author
|
Hi, Note that the conflict had to do with search history. Thanks. |
michaelDCurran
approved these changes
Jun 6, 2019
michaelDCurran
added a commit
that referenced
this pull request
Jun 6, 2019
nvdaes
added a commit
to nvdaes/placeMarkers
that referenced
this pull request
Jun 7, 2019
* The Specific search dialog will work even when the NVDA's About dialog is open, thanks to @josephsl: [NVDA PR 8595](nvaccess/nvda#8595) * The case sensitive checkbox state will be saved for the next search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8566
Summary of the issue:
NVDA's Find dialog (Control+NVDA+F) appeared to do nothing when NVDA's About dialog is open. As a result, find functionality doesn't work when Enter is pressed.
Description of how this pull request fixes the issue:
wxPython 4: somehow, Find dialog (Control+NVDA+F) doesn't work if NVDA's About dialog is opened. Mitigate this by giving this dialog the same treattment as elements list - creating a run callback.
Testing performed:
Ran Find dialog with or without NVDA's About dilaog opened. This was tested on Microsoft Edge, Firefox, and Internet Explorer.
Known issues with pull request:
None
Change log entry:
N/A (because this is a change brought by wxPython 4)