Braille in UIA word documents: improve focus ancestry, cursor routing, and newly inserted bullets/numbers#8576
Merged
Conversation
…nks configurable by subclasses.
Specifically: * strip the bullet off the start of the actual text and place it in the line-prefix formatField attribute. this allows braille cursor routing to work correctly on list items. * Work around a bug in MS Word where expanding to line on the final line of the document when it is blank fails. In this case, move the end of the range to to the end of the document manually. this allows NVDA to expose newly inserted bullets in both speech and braille.
…m is still announced on the first character like it used to. Now via a line-prefix_speakAlways boolean attribute.
…ving redundant reporting of the title.
LeonarddeR
reviewed
Jul 31, 2018
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
I will test drive this with a braille display later today.
| @@ -441,7 +441,10 @@ class ProtectedDocumentPane(IAccessible): | |||
| """The pane that gets focus in case a document opens in protected mode in word | |||
Collaborator
There was a problem hiding this comment.
This pane 'doesn't seem to be limited to protected documents only.
| def _get_name(self): | ||
| # Microsoft Word duplicates the full title of the document on this control, which is redundant as it appears in the title of the app itself. | ||
| # Translators: The name of a control that shows a Microsoft Word document. | ||
| return _("Microsoft Word") |
Collaborator
There was a problem hiding this comment.
Should this really be translatable as it is the name of an application? Personally, I'd vote for removing the name altogether, but that's just my personal preference.
…name is duplicated in the title of the application.
Member
Author
|
I completely removed the name of the word document control, and also
updated the docstring of the ProtectedDocumentPane. I'm unwilling to
rename the class itself as it causes needless code chirn and risk of
breakage.
|
LeonarddeR
previously approved these changes
Jul 31, 2018
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Wow, this is really a massive improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8407
Fixes #7971
Fixes #7970
Summary of the issue:
There are several issues with braille support for Microsoft word when using UI automation:
Description of how this pull request fixes the issue:
Testing performed:
Tested several complex documents with Microsoft word with UIA support enabled. Tested with both speech and braille.
Known issues with pull request:
None.
Change log entry:
Bug fixes: