Disable Welcome Dialog entry in the NVDA menu on secure screens#8536
Merged
Conversation
|
For transparency reasons I would prefer a changelog entry – even if it's an oversight. Well, and thanks for fixing this. btw: What are you thinking about bug #8521? |
ehollig
approved these changes
Oct 25, 2018
ehollig
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! I think it is up to @michaelDCurran or @feerrenrut whether #8521 should be included as a part of this PR. I do agree that a change log record should be added, maybe under bug fixes.
feerrenrut
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8520
Summary of the issue:
The "Welcome Dialog" entry in the NVDA menu on secure screens is useless.
Description of how this pull request fixes the issue:
This (small) PR removes this entry while NVDA is running in secure mode.
Testing performed:
Tested, it works for me.
Known issues with pull request:
None known
Change log entry:
Bug Fixes: