Remove redundant text from clock icon in system tray#8513
Merged
feerrenrut merged 5 commits intoAug 14, 2018
Conversation
dkager
previously approved these changes
Jul 28, 2018
dkager
left a comment
Contributor
There was a problem hiding this comment.
The code looks good. The two things to test are:
- Does this fix not affect other Windows versions?
- Are there still LTR/RTL characters in the clock in other Windows versions? It would be nice if this PR could address all supported Windows versions at once.
Contributor
Author
|
@dkager This PR addresses only original problem reported in #4364 and not deals with RTL character in the clock text. I've excluded later versions of Windows from a PR description, because there is no redundant information’s in the clock icon under them. My preference would be to wait until it is merged and then create additional PR which will fix #8361 |
Contributor
|
Fair enough. |
Contributor
Author
|
@dkager If i have your approval can you please request a review from @michaelDCurran or @feerenrut. I'd do it my self, but i am not a collaborator. I don't expect it to be included in 2018.3, but having it in master would let me work on #8361 more easily. |
feerrenrut
approved these changes
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thanks to @dkager for providing sample implementation.
Link to issue number:
Fixes #4364
Summary of the issue:
On some versions of Windows name of the clock icon in system tray contain information's present in the role or in the value.
Description of how this pull request fixes the issue:
If value is not empty we are dismissing the name.
Testing performed:
Tested the following
On Windows 10 Anniversary Update and later there is no double text, so i've just made sure, that it works as it should.
Known issues with pull request:
None known
Change log entry:
Section: Bug fixes
NVDA will no longer present redundant information when reading clock system tray on some versions of Windows.