Add apropriate messages when interacting with empty status lines #8475
Conversation
…mpty status bars
|
Hi, Apparently there is an indentation error in global commands file (line 1395), and Appveyor complains about this. Thanks. |
josephsl
left a comment
There was a problem hiding this comment.
Hi,
Besides going over indentation error, you can do this by simply adding a check for empty text right before counting how many key presses were there. You can do it in two ways:
- Combine check for no status bar object along with empty text so NvDA will say, "no status line found".
- Adding a check for empty string, and if it is truly empty, you can say, "no status line text found".
Thanks.
|
Hi, A tip: checking for empty text right before counting script count instead of going through each script count case makes this change way simpler to debug and saves bytecode generation. Thanks. |
|
Hi @josephsl |
|
Your approach has in my opinion one important disadvantage and it is the fact, that regardless of the user action the same message about empty status bar will be presented.
Hi, I’d argue that your approach has the same disadvantage: noa matter how many times users perform status bar command, it’ll say “no status bar information”, which is the same thing as announcing this info right away. Thanks.
|
|
Hi, I’d argue that your approach has the same disadvantage: noa matter how many times users perform status bar command, it’ll say “no status bar information”, which is the same thing as announcing this info right away. Thanks.
Not really, because when user attempts to copy status bar content
different message is presented.
|
|
Not really, because when user attempts to copy status bar content different message is presented.
Hi, hmmm, I beg to differ. If text is empty, surely one cannot copy the empty string to clipboard, right? Unless of course you want NVDA to say that there’s nothing to spell or copy. Also, another case of empty status line is internet Explorer. Thanks.
|
|
i've done it in this way, because in #7789 @feerrenrut says
|
|
So in effect then you want it to flag the difference between no status bar
present and one which has an empty string, so won't copy?
Maybe No status bar is sufficient to mean that to anyone. After all you
would not issue the command if you were told that to start with, and the
only difference between them is that in one case its missing and in the
other its empty. Do you need to know anything ore?
I know its not strictly correct, but the effect of doing a copy of its
contents will be the same. Brian
|
I think the reason behind this was to highlight difference in the two actions. It reflects that, despite attempting both similar but distinct actions, neither is able to succeed. |
|
Another thing if I may, instead of |
|
@Andre9642 Thanks for the tip. |
"Users are now informed when attempting to read or copy an empty status bar. (nvaccess#7789)"
The discussion around this review seems to be complete.
Link to issue number:
Fixes #7789
Summary of the issue:
When user reads empty status line the message "blank" is spoken and when attempting to copy it nothing is announced.
Description of how this pull request fixes the issue:
When user attempts to read, spell or copy empty status line appropriate message is presented.
Testing performed:
Tested with Firefox status bar. I'm aware, that Firefox's status bar is simply a badly implemented and not exactly empty, but i cannot find a app with real empty status bar.
Known issues with pull request:
None
Change log entry:
Section: Bug fixes
When user interacts with empty status bar NVDA will now inform user about it.