Report virtual desktop switches in Windows 10 by michaelDCurran · Pull Request #8259 · nvaccess/nvda

michaelDCurran · 2018-05-11T00:42:24Z

Link to issue number:

Summary of the issue:

In Windows 10, it is possible to have different virual desktops, so as to switch between large groups of applications.
To switch between desktops, press control+windows+left/rightArrow.
NVDA however does not report when the desktop changes.

Description of how this pull request fixes the issue:

Partly taken from @josephsl's Windows 10 App Essentials, but improved to better handle the ordering of announcements.
Specifically:

Added eventHandler.handlePossibleDesktopNameChange function. This function checks to see if the Desktop's name has changed since the last time it was called. If so, then it reports the new desktop name. it fetches the desktop name off the root UIAutomation element. Also, this function does nothing on Windows versions lower than Windows 10.
eventHandler.doPreGainFocus now calls handlePossibleDesktopNameChange, but only after any possible foreground event, so as to ensure that speech is not interrupted. In short this means that the desktop name will be announced before the new focus and its ancestry, but after speech is canceled due to a foreground change.
handlePossibleDesktopNameChange is also called for nameChange events on the Desktop itself. However, NVDA delays the execution of handlePossibleDesktopNamechange in this case by 250 ms, to ensure that it executes after any other possible focus changes. Of course if a focus change did detect the desktop name change, then the delayed call from the name change event will simply do nothing. The reason for the call in the name change event is to handle the situations where the desktop changes but there is no focus event, such as when focused on the taskbar.

Testing performed:

Ran NVDA on Windows 10. Switched between multiple virtual desktops. Confirmed that the new desktop name was reported. This test was done both with focus in an application, and on the taskbar.

Known issues with pull request:

None.

Change log entry:

New features:

The name of the current virtual desktop on windows 10 is now reported when switching virtual desktops.

josephsl

Hi,

This breaks if a virtual desktop contains File Explorer windows and this is seen as the focused item.

STR:

Create multiple desktops.
On One of them, open File Explorer.

Expected: desktop position is announced before File Explorer focus announcement is made.
Actual: Desktop announcement is cut off by focus announcement on File Explorer windows.

This was tested on Version 1803 (RS4/build 17134).

Thanks.

michaelDCurran · 2018-05-11T01:15:51Z

When you say the desktop name is cut off, do you mean you don't hear it at all? What exactly are you focused on when you do this. Is it a file list item? I am finding this hard to reproduce. I'm seeing a slightly different bug now though where NVDA is sometimes getting the name "Desktop" when switching desktops, rather than say "Desktop 1". But it only seems to happen sometimes when the system is a bit slow, or when tabbed sets are getting a bit confused in Thunderbird for example.

josephsl · 2018-05-11T01:19:50Z

Hi,

Cutting off: I briefly hear the first syllables of the desktop name before it is cut off by the focus announcement for File Explorer's folders list.

Thanks.

michaelDCurran · 2018-05-11T01:21:54Z

Actually, Narrator is having the same bug with just saying "Desktop" sometimes in build 17666. In both NVDA and Narrator when this occurs, there is also a bit of a pause before hand. I think something is broken in that build with the desktop UIAElement's name property.

michaelDCurran · 2018-05-11T02:30:33Z

Are you running any other add-ons when testing this? For me if I am positioned on a file called words.txt in my user directory, and from a separate virtual desktop I switch back to this virtual desktop I hear: desktop 1 Michael Curran Items view list words.txt 60 of 60 I.e. the cancel speech occured before "Desktop 1"

josephsl · 2018-05-11T02:52:25Z

Hi, no add-ons were running. Also, this was noticeable when File Explorer was open on desktop 1, and I can confirm the delay. Thanks. From: Michael Curran <notifications@github.com> Sent: Thursday, May 10, 2018 7:31 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Review requested <review_requested@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) Are you running any other add-ons when testing this? For me if I am positioned on a file called words.txt in my user directory, and from a separate virtual desktop I switch back to this virtual desktop I hear: desktop 1 Michael Curran Items view list words.txt 60 of 60 I.e. the cancel speech occured before "Desktop 1" — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#8259 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkBJaKM6OFSCPS8-9u-QvaaEYDrM-ks5txPfQgaJpZM4T6vwF> .

PratikP1 · 2018-05-14T17:15:00Z

If this is the same implementation as win10AppEssentials add-on, the trouble may arise from the announcement being made after everything else is spoken. For example, if I’m focused on an inbox item, the entire list item is read along with the app and other info before “desktop x” is announced. I can also confirm that the desktop number announcement is also being cut off with Narrator. I’ll file that bug.

josephsl · 2018-05-14T17:17:00Z

Hi, @michaelDCurran modified my implementation so desktop ID can be announced before any focus event that may arise due to desktop switches. Thanks. From: PratikP1 <notifications@github.com> Sent: Monday, May 14, 2018 10:15 AM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Review requested <review_requested@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) If this is the same implementation as win10AppEssentials add-on, the trouble may arise from the announcement being made after everything else is spoken. For example, if I’m focused on an inbox item, the entire list item is read along with the app and other info before “desktop x” is announced. I can also confirm that the desktop number announcement is also being cut off with Narrator. I’ll file that bug. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#8259 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkHIfxcZTQqcDYqNSzOIhYy4lyPU2ks5tybuXgaJpZM4T6vwF> .

PratikP1 · 2018-05-14T17:20:43Z

Sorry for not noticing the pull request description.

michaelDCurran · 2018-05-14T23:33:47Z

@PratikP1 If you could share the narrator bug you file, either publically or with me privately that would be much appreciated. I'd like to follow up with Microsoft internally. It looks like the call to actually get the desktop name, whether that be via MSAA or UIA hangs for 200 ms and then just returns "Desktop", if called as soon as the foreground change occurs. Thus, then NVDA and Narrator both just announce "Desktop" rather than say "Desktop 1".

PratikP1 · 2018-05-15T13:27:05Z

@michaelDCurran Here is the feedback link: https://aka.ms/AA1ajhj
I included your analysis of the 200MS delay in the description.

michaelDCurran · 2018-06-19T22:17:09Z

This seems to be working well for me now in 17692. @josephsl can you confirm this as well?

michaelDCurran · 2018-06-19T22:18:05Z

If so I think we should limit this code to 17692 and above as it is broken in lower builds (including the last stable Windows 10 update).

josephsl · 2018-06-19T23:36:51Z

Hi, there appears to be a problem though: when I create multiple desktops and switch between them, NVDA announces “Desktop”, followed by the focused element, and then announces the title of the just switched desktop object. Thanks. From: Michael Curran <notifications@github.com> Sent: Tuesday, June 19, 2018 3:17 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) This seems to be working well for me now in 17692. @josephsl <https://github.com/josephsl> can you confirm this as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkEu_xwDzCAj5SddjTaIyioOyQXrtks5t-XhogaJpZM4T6vwF> .

josephsl · 2018-06-19T23:39:08Z

Hi, as a follow-up, it is more consistent (at least with brief testing). I’m trying to figure out a scenario that can cause our implementation to fail noticeably. Thanks. From: Michael Curran <notifications@github.com> Sent: Tuesday, June 19, 2018 3:17 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) This seems to be working well for me now in 17692. @josephsl <https://github.com/josephsl> can you confirm this as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkEu_xwDzCAj5SddjTaIyioOyQXrtks5t-XhogaJpZM4T6vwF> .

josephsl · 2018-06-19T23:47:14Z

Hi,

Testing with Korean as well: looks like we might be able to do a workaround: if the name of the object is "Desktop" (for which we have translations for), then we could safely assume that we need to delay announcing new desktop title (I'm sure there are better solutiosn out there).

As this also affects servers, I think it might be best to mention Windows Server 2019 Desktop Experience in the what's new document.

Thanks.

michaelDCurran · 2018-06-20T00:30:55Z

In that case, if it is still broken in 17692, then we will wait further until it is addressed properly by Microsoft.

josephsl · 2018-07-19T01:11:44Z

Hi,

Looks like it is working as designed (so far) in build 17713.

Thanks.

michaelDCurran · 2018-07-19T02:30:48Z

I'm still seeing the issue on 17713. Especially if I have a wsl console on desktop 1. It just says desktop, after a 1 to 2 second delay.

PratikP1 · 2018-07-19T19:03:06Z

I’m still seeing problems with this as well. I don’t think it’s quite resolved yet.

josephsl · 2018-08-31T02:11:36Z

Hi,

Looks like we need to:

Resolve conflicts.
Make sure it works on build 17700 series (it doesn't even announce desktop switches in 17744 on my computer).

Thanks.

The desktop is checked on focus changes, and also the desktop's own name changes in case the focus does not move (such as when on the task bar).

josephsl · 2018-08-31T02:24:30Z

Hi,

Never mind about desktop switch not announced in build 17744 - I was running from source. Thanks.

josephsl · 2018-08-31T02:42:26Z

Hi,

Update: looks like it is better in build 17744 - with WSL open on a virtual desktop, NVDA does announce which desktop one is switching to.

@PratikP1, is this the case for you in build 17744 (slow)/17746 (fast)/18219 (skip ahead)? Does more recent builds remedy issues you've reported?

Thanks.

PratikP1 · 2018-08-31T14:05:35Z

Unfortunately, the issues I reported remain the same in 17746.100. To summarize: With 4 virtual desktops running, desktop 1 is the most problematic. On occasion, "desktop 1" is announced. More often than not, however, only "desktop" is announced when navigating to the first desktop. All other desktops are announced. I still believe that the desktop announcement should take precedents over focused window. It should be number of desktop > focused window rather than focused window > number of desktop.

michaelDCurran · 2019-02-20T23:00:00Z

This is working very well for me in Windows build 8334.0. It is always accurate, and I don't even see the strange delay I used to get. Can you confirm @josephsl that this also works for you in this build or later? We'll have to limit to this build as a minimum though before merging if we do.

josephsl · 2019-02-20T23:17:24Z

Hi, I’ll test the latest commits with 18329, 18334, 18342, and 18836 and report back by tonight at the earliest. Thanks. From: Michael Curran <notifications@github.com> Sent: Wednesday, February 20, 2019 3:00 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) This is working very well for me in Windows build 8334.0. It is always accurate, and I don't even see the strange delay I used to get. Can you confirm @josephsl <https://github.com/josephsl> that this also works for you in this build or later? We'll have to limit to this build as a minimum though before merging if we do. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkAIc85wdiGBt1cd4P08_CqBTsgVfks5vPdNzgaJpZM4T6vwF> .

josephsl · 2019-02-21T05:41:48Z

Hi,.

Results:

18329: delay observed.
18334: no delay
18342: no delay

So far, the code matches Mick's predictions and observations. Thanks.

dpy013 · 2019-05-17T14:05:03Z

Hi,

Two things:

April 2019 Update -> May 2019 Update.

NVDA might not report "Desktop 1" under the following scenario: user opens many desktops, then moves to a previous desktop, closes virtual desktops, focus moves to first virtual desktop. From there, whenever desktops are closed, NVDA won't report "Desktop 1". Personally, I'm okay with this approach, but I imagine someone might ask us in the future to revisit the approach proposed - comparing new versus last stored desktop title.

As for the first one, would you like to do it or let me take care of it once 2019.2 beta ships?

Thanks.
hi josephsl
My suggestion is to solve this problem once and for all.
thank

josephsl · 2019-05-17T15:11:47Z

Hi, which one – first or the second? If the second, the current approach was done in order to avoid repetitions. Thanks. From: eric <notifications@github.com> Sent: Friday, May 17, 2019 7:05 AM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) Hi, Two things: 1. April 2019 Update -> May 2019 Update. 2. NVDA might not report "Desktop 1" under the following scenario: user opens many desktops, then moves to a previous desktop, closes virtual desktops, focus moves to first virtual desktop. From there, whenever desktops are closed, NVDA won't report "Desktop 1". Personally, I'm okay with this approach, but I imagine someone might ask us in the future to revisit the approach proposed - comparing new versus last stored desktop title. As for the first one, would you like to do it or let me take care of it once 2019.2 beta ships? Thanks. hi josephsl My suggestion is to solve this problem once and for all. thank — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259?email_source=notifications&email_token=AB4AXEEL35H5VG5HQQ32MQ3PV23RHA5CNFSM4E7K7QC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVU3CFI#issuecomment-493465877> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEHTNGL5JOQAJOHEMHTPV23RHANCNFSM4E7K7QCQ> .

dpy013 · 2019-05-19T23:14:52Z

Hi, which one – first or the second? If the second, the current approach was done in order to avoid repetitions. Thanks. From: eric notifications@github.com Sent: Friday, May 17, 2019 7:05 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) Hi, Two things: 1. April 2019 Update -> May 2019 Update. 2. NVDA might not report "Desktop 1" under the following scenario: user opens many desktops, then moves to a previous desktop, closes virtual desktops, focus moves to first virtual desktop. From there, whenever desktops are closed, NVDA won't report "Desktop 1". Personally, I'm okay with this approach, but I imagine someone might ask us in the future to revisit the approach proposed - comparing new versus last stored desktop title. As for the first one, would you like to do it or let me take care of it once 2019.2 beta ships? Thanks. hi josephsl My suggestion is to solve this problem once and for all. thank — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259?email_source=notifications&email_token=AB4AXEEL35H5VG5HQQ32MQ3PV23RHA5CNFSM4E7K7QC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVU3CFI#issuecomment-493465877> , or mute the thread https://github.com/notifications/unsubscribe-auth/AB4AXEHTNGL5JOQAJOHEMHTPV23RHANCNFSM4E7K7QCQ .

hi josephsl
Is the first
thank

josephsl · 2019-05-19T23:27:05Z

Hi, yep, thanks for clarifying. From: eric <notifications@github.com> Sent: Sunday, May 19, 2019 4:15 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) Hi, which one – first or the second? If the second, the current approach was done in order to avoid repetitions. Thanks. From: eric notifications@github.com <mailto:notifications@github.com> Sent: Friday, May 17, 2019 7:05 AM To: nvaccess/nvda nvda@noreply.github.com <mailto:nvda@noreply.github.com> Cc: Joseph Lee joseph.lee22590@gmail.com <mailto:joseph.lee22590@gmail.com> ; Mention mention@noreply.github.com <mailto:mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259 <#8259> ) Hi, Two things: 1. April 2019 Update -> May 2019 Update. 2. NVDA might not report "Desktop 1" under the following scenario: user opens many desktops, then moves to a previous desktop, closes virtual desktops, focus moves to first virtual desktop. From there, whenever desktops are closed, NVDA won't report "Desktop 1". Personally, I'm okay with this approach, but I imagine someone might ask us in the future to revisit the approach proposed - comparing new versus last stored desktop title. As for the first one, would you like to do it or let me take care of it once 2019.2 beta ships? Thanks. hi josephsl My suggestion is to solve this problem once and for all. thank — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259 <#8259> ?email_source=notifications&email_token=AB4AXEEL35H5VG5HQQ32MQ3PV23RHA5CNFSM4E7K7QC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVU3CFI#issuecomment-493465877> , or mute the thread https://github.com/notifications/unsubscribe-auth/AB4AXEHTNGL5JOQAJOHEMHTPV23RHANCNFSM4E7K7QCQ . hi josephsl Is the first thank — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259?email_source=notifications&email_token=AB4AXEELXUSB2TM44Y4XFQDPWHNPBA5CNFSM4E7K7QC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXMXMQ#issuecomment-493800370> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEDM3N5KOYQ5JOTVXYDPWHNPBANCNFSM4E7K7QCQ> .

josephsl

Hi,

Resolved the conflict, and comment has been updated.

Thanks.

dpy013 · 2019-05-21T06:32:42Z

thank josephsl

josephsl · 2019-05-21T06:39:25Z

Hi, you should thank @michaelDCurran instead for his hard work on bringing this to life. Thanks. From: eric <notifications@github.com> Sent: Monday, May 20, 2019 11:33 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) thank josephsl — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259?email_source=notifications&email_token=AB4AXEEN6HFQBEZ4SUT3SGLPWOJQ3A5CNFSM4E7K7QC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV24RXA#issuecomment-494258396> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEETMJ7G2DJ6M6HHVRTPWOJQ3ANCNFSM4E7K7QCQ> .

beqabeqa473 · 2019-05-27T12:38:10Z

hello.

this change broke nvda in some situations.
specifically, openning nvda menu freezes, also messageboxes which are openning also are spoken after a second or 2.

michaelDCurran · 2019-05-27T22:07:24Z

I've now seen multiple people state that this pr causes freezes in the NVDA menu. I can't reproduce this myself, but most likely we'll have to revert this pr.

michaelDCurran · 2019-05-27T22:09:55Z

this change broke nvda in some situations.
specifically, openning nvda menu freezes, also messageboxes which are openning also are spoken after a second or 2.
@beqabeqa473 If you have not already, can you please try this with all add-ons disabled?

This reverts commit 0d29265.

michaelDCurran · 2019-05-27T22:25:30Z

Here is a try build of master with this pr reverted: https://ci.appveyor.com/api/buildjobs/7n0cgffqatnr3qch/artifacts/output%2Fnvda_snapshot_try-revert_i5641-17363%2C6490bbf3.exe
@beqabeqa473 Does this issue go away when running this try build?

beqabeqa473 · 2019-05-27T22:46:28Z

hi. i am not 100% sure but, maybe issue is when running 1809 update. now on 18898 i don't have this issue. i will try on another computer where i have an issue in few hours when addons disabled and try build. although i don't think trybuild will tell something. i've downloaded a version just before merging this pr and everything was ok. so, potentially, issue could be on 1809 update or with some addon running. i will test that and will write back.

…

On 5/28/19, Michael Curran ***@***.***> wrote: Here is a try build of master with this pr reverted: https://ci.appveyor.com/api/buildjobs/7n0cgffqatnr3qch/artifacts/output%2Fnvda_snapshot_try-revert_i5641-17363%2C6490bbf3.exe @beqabeqa473 Does this issue go away when running this try build? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #8259 (comment)

-- with best regards beqa

beqabeqa473 · 2019-05-28T08:09:28Z

hello. here are my observations. running latest master with change from this pr and with all addons disabled, i can still reproduce freezes in nvda gui. installing trybuild eliminates these freezes. it is on windows 10 1809 october 2018 update. i don't have may 2019 update, but on latest insider build, i cannot reproduce these freezes with latest master. if anyone could test latest master with may 2019 update will be good. at this time, on october 2018 update i can reproduce these freezes.

…

On 5/28/19, Beqa Gozalishvili ***@***.***> wrote: hi. i am not 100% sure but, maybe issue is when running 1809 update. now on 18898 i don't have this issue. i will try on another computer where i have an issue in few hours when addons disabled and try build. although i don't think trybuild will tell something. i've downloaded a version just before merging this pr and everything was ok. so, potentially, issue could be on 1809 update or with some addon running. i will test that and will write back. On 5/28/19, Michael Curran ***@***.***> wrote: > Here is a try build of master with this pr reverted: > https://ci.appveyor.com/api/buildjobs/7n0cgffqatnr3qch/artifacts/output%2Fnvda_snapshot_try-revert_i5641-17363%2C6490bbf3.exe > @beqabeqa473 Does this issue go away when running this try build? > > -- > You are receiving this because you were mentioned. > Reply to this email directly or view it on GitHub: > #8259 (comment) -- with best regards beqa

-- with best regards beqa

LeonarddeR · 2019-05-28T08:20:15Z

I'm running version 1903 and experience these freezes once in a while, though not very prevalent. Having said that, I'd like to vote for a revert of this pr in order to give us time to find out what's the culprit here.

beqabeqa473 · 2019-05-28T08:23:11Z

here on 1809 it is in 99 times of 100.

…

On 5/28/19, Leonard de Ruijter ***@***.***> wrote: I'm running version 1903 and experience these freezes once in a while, though not very prevalent. Having said that, I'd like to vote for a revert of this pr in order to give us time to find out what's the culprit here. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #8259 (comment)

-- with best regards beqa

josephsl · 2019-05-28T08:29:04Z

Hi, Mick, after reverting this, can we try introducing isolated try builds i.e. a try build for each file that has changed and can be isolated? I’m thinking one of the commit streams from the PR branch might be responsible for this. Thanks. From: Leonard de Ruijter <notifications@github.com> Sent: Tuesday, May 28, 2019 1:20 AM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Report virtual desktop switches in Windows 10 (#8259) I'm running version 1903 and experience these freezes once in a while, though not very prevalent. Having said that, I'd like to vote for a revert of this pr in order to give us time to find out what's the culprit here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8259?email_source=notifications&email_token=AB4AXEEAQIN4JN2X7ZXZD5LPXTTMFA5CNFSM4E7K7QC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWLLATI#issuecomment-496414797> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEAX62X4WU5SMMXSEG3PXTTMFANCNFSM4E7K7QCQ> .

This reverts commit 0d29265.

nvaccess#9629) This reverts commit 0d29265.

Desktop switches can only be reported on Windows 10 May 2019 and above. Previous Windows 10 builds could experience delays and incorrect desktop names. Implementation details: 1. Added a Desktop IAccessible NVDAObject which is now used instead of the Desktop Window NVDAObject. This is used for api.getDesktopObject(). It is also used to retrieve the name and to catch nameChange events (see below). Querying of the name via IAccessible is disabled altogether before Windows 10 may 2019, in which case it is hard-coded like it was before this PR. 2. Added eventHandler.handlePossibleDesktopNameChange function. This function checks to see if the Desktop's name has changed since the last time it was called. If so, then it reports the new desktop name. It fetches the desktop name using the Desktop IAccessible object. 3. eventHandler.doPreGainFocus now calls handlePossibleDesktopNameChange, but only after any possible foreground event, so as to ensure that speech is not interrupted. In short this means that the desktop name will be announced before the new focus and its ancestry, but after speech is canceled due to a foreground change. 4. handlePossibleDesktopNameChange is also called for nameChange events on the Desktop IAccessible object. However, NVDA delays the execution of handlePossibleDesktopNameChange in this case by 250 ms, to ensure that it executes after any other possible focus changes. Of course if a focus change did detect the desktop name change, then the delayed call from the name change event will simply do nothing. The reason for the call in the name change event is to handle the situations where the desktop changes but there is no focus event, such as when focused on the taskbar. Co-authored-by: Michael Curran <mick@nvaccess.org>

michaelDCurran requested a review from josephsl May 11, 2018 00:42

josephsl reviewed May 11, 2018

View reviewed changes

Report virtual desktop switches in Windows 10.

f924868

The desktop is checked on focus changes, and also the desktop's own name changes in case the focus does not move (such as when on the task bar).

josephsl force-pushed the i5641 branch from 31c7ebe to f924868 Compare August 31, 2018 02:13

josephsl added 2 commits May 20, 2019 23:20

Merged master

e32a90a

Event handler: April 2019 -> May 2019 Update

c36aa6b

josephsl approved these changes May 21, 2019

View reviewed changes

michaelDCurran added 2 commits May 22, 2019 11:12

Merge branch 'master' into i5641

db20c78

Update what's new.

9a5f438

michaelDCurran merged commit 0d29265 into master May 22, 2019

nvaccessAuto added this to the 2019.2 milestone May 22, 2019

michaelDCurran added a commit that referenced this pull request May 27, 2019

Revert "Report virtual desktop switches in Windows 10 (#8259)"

6490bbf

This reverts commit 0d29265.

michaelDCurran mentioned this pull request May 28, 2019

Revert "Report virtual desktop switches in Windows 10 (#8259)" #9629

Merged

michaelDCurran added a commit that referenced this pull request May 28, 2019

Revert "Report virtual desktop switches in Windows 10 (#8259)" (#9629)

c12f0ae

This reverts commit 0d29265.

codeofdusk pushed a commit to codeofdusk/nvda that referenced this pull request May 31, 2019

Revert "Report virtual desktop switches in Windows 10 (nvaccess#8259)" (

4d575f4

nvaccess#9629) This reverts commit 0d29265.

jcsteh mentioned this pull request Apr 19, 2020

Windows 10: NVDA does not report which desktop I am on when I switch amongst multiple desktops #5641

Closed

jcsteh mentioned this pull request Apr 19, 2020

Report virtual desktop switches in Windows 10 #11031

Closed

josephsl mentioned this pull request May 7, 2023

Windows 10/11 virtual desktop switch announcements (take 3): use a combination of name change event and a dedicated event handler function to announce virtual desktop switches in Windows 10 Version 1903 and later #14910

Closed

6 tasks

Uh oh!

Conversation

michaelDCurran commented May 11, 2018

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Change log entry:

Uh oh!

josephsl left a comment

Choose a reason for hiding this comment

Uh oh!

michaelDCurran commented May 11, 2018 via email

Uh oh!

josephsl commented May 11, 2018

Uh oh!

michaelDCurran commented May 11, 2018 via email

Uh oh!

michaelDCurran commented May 11, 2018 via email

Uh oh!

josephsl commented May 11, 2018 via email

Uh oh!

PratikP1 commented May 14, 2018 via email

Uh oh!

josephsl commented May 14, 2018 via email

Uh oh!

PratikP1 commented May 14, 2018

Uh oh!

michaelDCurran commented May 14, 2018

Uh oh!

PratikP1 commented May 15, 2018

Uh oh!

michaelDCurran commented Jun 19, 2018

Uh oh!

michaelDCurran commented Jun 19, 2018

Uh oh!

josephsl commented Jun 19, 2018 via email

Uh oh!

josephsl commented Jun 19, 2018 via email

Uh oh!

josephsl commented Jun 19, 2018

Uh oh!

michaelDCurran commented Jun 20, 2018

Uh oh!

josephsl commented Jul 19, 2018

Uh oh!

michaelDCurran commented Jul 19, 2018 via email

Uh oh!

PratikP1 commented Jul 19, 2018 via email

Uh oh!

josephsl commented Aug 31, 2018

Uh oh!

josephsl commented Aug 31, 2018

Uh oh!

josephsl commented Aug 31, 2018

Uh oh!

PratikP1 commented Aug 31, 2018

Uh oh!

michaelDCurran commented Feb 20, 2019

Uh oh!

josephsl commented Feb 20, 2019 via email

Uh oh!

josephsl commented Feb 21, 2019

Uh oh!

dpy013 commented May 17, 2019

Uh oh!

josephsl commented May 17, 2019 via email

Uh oh!

dpy013 commented May 19, 2019

Uh oh!

josephsl commented May 19, 2019 via email

Uh oh!

josephsl left a comment

Choose a reason for hiding this comment

Uh oh!

dpy013 commented May 21, 2019

Uh oh!

josephsl commented May 21, 2019 via email

Uh oh!