Show proper display description when listing manually added braille display gestures in the input gestures dialog#8245
Conversation
|
@dkager: Would be good to know whether you have anything to say about this, since it was one of your annoyances until now ;) |
|
does this need to incubate? |
|
Hmm yes, I think it should. |
|
Hi, Appveyor says the build process has failed, with the build log showing that one of the unit tests didn't pass. Thanks. |
|
Thanks for pointing out. I will undo the incubation and will request for another review after the unit test conflict has been resolved. |
|
@michaelDCurran: Could you do a review of the last changes before we incubate this again? |
…isplay gestures in the input gestures dialog. Incubates #8245
|
This has been removed from next again. Unittests failed. If they are succeeding on this branch but not on next, it may be possible that new merges of this branch into next are breaking as there was a previous revert. Git does not cope well with this. A casing point as to why we are considering the new release process with PRs squashing merging straight to master. |
|
@michaelDCurran: What would be the best way to incubate this? |
|
You could rebase this branch on master and then we could incubate to next again. However, be aware that this will cause any review comments to become invalid. |
|
Thanks, I just rebased this unto master, thereby squashing everything into one commit. |
Link to issue number:
Closes #8108
Summary of the issue:
When adding a braille display gesture to a script using the input gestures dialog, the added gesture shows up along with the description of the current display. However, when changing the current braille display, the gesture added earlier always shows up with the currently active display, not with the display driver description the gesture identifier belongs to.
Description of how this pull request fixes the issue:
Testing performed:
Known issues with pull request:
None
Change log entry: