Restore handytech COM server#8213
Conversation
|
@michaelDCurran commented on 30 apr. 2018 05:59 CEST:
It would be good to explicitly state that this applies to the handy tech driver that is shipped in their add-on. |
LeonarddeR
left a comment
There was a problem hiding this comment.
There used to be an entry in readme.md, I don't insist on having that one restored though.
It would be good to have this incubate in next to make sure the comtypes update doesn't regress something else.
|
Well, if we state this,
We sould add a reference to the driver in the user-guide.
Wysłane z aplikacji Poczta dla Windows 10
Od: Leonard de Ruijter
Wysłano: poniedziałek, 30 kwietnia 2018 09:02
Do: nvaccess/nvda
DW: Subscribed
Temat: Re: [nvaccess/nvda] Restore handytech COM server (#8213)
@michaelDCurran commented on 30 apr. 2018 05:59 CEST:
Bug fixes:
• It is again possible to use the older Handytech braille display driver in order to access some manufacturer-specific features.
It would be good to explicitly state that this applies to the handy tech driver that is shipped in their add-on.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I disagree with mentioning it in the user Guide. We are only adding this
back for those who must use the add-on. We are not encouraging it.
|
|
I agree with @michaelDCurran. |
|
I'm afraid comtypes 1.1.4 introduces another regression, see enthought/comtypes#145. I've seen this error in Outlook as well as when creating new comtypes wrappers. To reproduce:
|
|
It looks like enthought/comtypes@98f6a42 is the culprit. I suggest reverting comtypes to enthought/comtypes@edbaf3b |
| For reference, the following dependencies are included in Git submodules: | ||
|
|
||
| * [comtypes](https://github.com/enthought/comtypes), version 1.1.3 | ||
| * [comtypes](https://github.com/enthought/comtypes), version 1.1.4 |
There was a problem hiding this comment.
Strictly spoken, tthis is not true any more. However functionally, this is equal to 1.1.4 minus the gen_path patch Python 2 doesn't benefit from anyway.
Link to issue number:
None.
Summary of the issue:
Although NVDA now supports Handytech braille displays natively, user still must use the old Handytech COM server driver if they want auto detection of Handytech displays, and support for ATC.
Recently the Handytech COM server was removed from NVDA making this impossible.
Handytech has requested we reintroduce this for now until Braille Display Auto Detection and ATC support is in NVDA.
Description of how this pull request fixes the issue:
The PR does the following:
Testing performed:
It would be good if @FelixGruetzmacher could test the following build with the Handytech COM server driver and ensure everything works correctly:
https://ci.appveyor.com/api/buildjobs/94ol47g4nf1wfbk2/artifacts/output%2Fnvda_snapshot_try-restoreHandytechServer-15069%2C7c747931.exe
Known issues with pull request:
None.
Change log entry:
Bug fixes: