Fix Smart Beetle scroll keys#8198
Merged
Merged
Conversation
feerrenrut
approved these changes
Apr 24, 2018
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Happy for this to be incubated when you are ready.
| 0x10<<8: "f4" | ||
| 0x10<<8: "f4", | ||
| 0x20<<8: "leftSideScroll", | ||
| 0x40<<8: "rightSideScroll" |
Contributor
There was a problem hiding this comment.
Minor: leave a comma on the end so that when there is an addition, the diff is just additions.
|
Hi, Awesome, I’m running the snapshot and the scroll wheels are working as expected. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #6086
Summary of the issue:
The Hims Smart Beetle has an internal issue, allowing both the left and right scroll key to send two different key codes, one key code specific to the Braille Sense Classic, and one specific to the Smart Beetle. This has initially been fixed, but regressed again in #7865, for which I'd like to say sorry.
Description of how this pull request fixes the issue:
Moved the two scroll keys that were missing from the SmartBeetle model class from the BrailleSense2S class to the base Model class.
Testing performed:
With a Smart Beetle, I no longer intentionally received the "Unknown key" message in the NVDA log.
Known issues with pull request:
None
Change log entry: