Add a appModule for taskMan, to fix some bugs in windows ten.#8147
Conversation
|
should I request a review from NV Access? |
|
I have Windows 7 if you have an add on, perhaps we could test it might be
safer for the unwashed to try!
Ie me!
|
| from NVDAObjects import NVDAObject | ||
| from NVDAObjects.UIA import UIA | ||
|
|
||
| def appropriateDescendant(obj): |
There was a problem hiding this comment.
Either a docstring here or a name that better explains what this function is for.
There was a problem hiding this comment.
I'd say the doc string is now clear, but still personally I'd prefer a name like isChildOfRow
| obj = obj.parent | ||
| return False | ||
|
|
||
| class BrokenUIAChild(NVDAObject): |
There was a problem hiding this comment.
Should inherit from UIA as it would not work with any other type of NVDAObject.
| from NVDAObjects import NVDAObject | ||
| from NVDAObjects.UIA import UIA | ||
|
|
||
| def appropriateDescendant(obj): |
There was a problem hiding this comment.
I'd say the doc string is now clear, but still personally I'd prefer a name like isChildOfRow
| #This is an icon and really is layout. Don't show it. | ||
| return | ||
| if obj.presentationType == obj.presType_layout and appropriateDescendant(obj): | ||
| clsList.insert(0, BrokenUIAChild) No newline at end of file |
There was a problem hiding this comment.
Please add an empty line below.
|
It is actually interesting to compare this issue with what I described in #7949 (comment) . There seem to be several similarities, particularly the fact that both the task manager and the outlook conversations view are kind of a data grid tree view hybrid. I wonder whether these issues have the same underlying UIA bug. |
|
hi.
i don't know if it is related but what can be done to improve
performance of openning taskmanager in win10?
with narrator running on my laptop it is openning very fast, in about
3 seconds, with nvda running it is taking 20-30 seconds taskmanager to
come up.
…On 4/9/18, Leonard de Ruijter ***@***.***> wrote:
It is actually interesting to compare this issue with what I described in
#7949 (comment) . There
seem to be several similarities, particularly the fact that both the task
manager and the outlook conversations view are kind of a data grid tree view
hybrid. I wonder whether these issues have the same underlying UIA bug.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#8147 (comment)
--
with best regards beqa
|
|
I wonder if app list in the “apps and features” setting is the same.
|
|
Is it broken with simple review? I just tested it in simple review, and it worked. |
|
Okay guys, I addressed @LeonarddeR review actions. I'm ready. |
LeonarddeR
left a comment
There was a problem hiding this comment.
Just one thing, not related to the code as such. Furthermore, if we could somehow report this at Microsoft to get fixed, that would be preferred.
| return | ||
| if obj.presentationType == obj.presType_layout and isChildOfRow(obj): | ||
| clsList.insert(0, BrokenUIAChild) | ||
|
No newline at end of file |
There was a problem hiding this comment.
Please make this an empty line
|
done |
|
I have an open bug regarding this with Microsoft. The last I heard about it was that they're not intending to fix because it sort of works with Narrator. If one of you can provide me ith a little more technical info, I can go back and make another argument for a fix. Thank you. |
|
Should this pull request be linked to issue #7148? |
|
Looks like the diff still shows one single tab instead of nothing.
|
|
@PratikP1 commented on 13 Apr 2018, 14:15 CEST:
Could #7949 (comment) help you in any way? I'm still pretty sure it's related. @PratikP1 commented on 9 Apr 2018, 16:19 CEST:
That is a list, no tree view I believe. |
|
@PratikP1 commented on 13 Apr 2018, 14:17 CEST:
If you think that this pr will fix it, and I think it does, then sure. |
rename to isChildOfRow
9f7a938 to
9d4b98d
Compare
|
I just rebased the fixes for review on master. |
Link to issue number:
None
Summary of the issue:
In windows ten, task manager has a bug where the columns for CPU usage, memory, and other information about a process are UIA layout, not content. This fix makes these columns UIA content, so NVDA shows them when using simple review mode.
Testing performed:
Built NVDA, installed it, and ran it on task manager on windows ten, version 1709.
Known issues with pull request:
It might or might not work on 8 and 7, I need someone to test this if possible.### Change log entry: