Fix model specific gestures for Hims displays#8100
Merged
Conversation
added 2 commits
March 16, 2018 21:26
michaelDCurran
approved these changes
Apr 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8096
Summary of the issue:
When pressing model specific gestures on several Hims displays, including the Braille Edge, the global mappings are used rather than the model specific ones.
Description of how this pull request fixes the issue:
Model identifiers in gestures ought to be without spaces, however spaces weren't stripped from the model names in the Hims driver.
This pr also improves the regex for model specific gestures, using a non-capturing group for the model specific identifier including the preceding dot.
Testing performed:
Reported to work as expected by @Piciok in #8096 (comment)
Known issues with pull request:
None
Change log entry: