Skip to content

Fix model specific gestures for Hims displays#8100

Merged
michaelDCurran merged 2 commits into
nvaccess:masterfrom
BabbageCom:i8096
Apr 20, 2018
Merged

Fix model specific gestures for Hims displays#8100
michaelDCurran merged 2 commits into
nvaccess:masterfrom
BabbageCom:i8096

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #8096

Summary of the issue:

When pressing model specific gestures on several Hims displays, including the Braille Edge, the global mappings are used rather than the model specific ones.

Description of how this pull request fixes the issue:

Model identifiers in gestures ought to be without spaces, however spaces weren't stripped from the model names in the Hims driver.

This pr also improves the regex for model specific gestures, using a non-capturing group for the model specific identifier including the preceding dot.

Testing performed:

Reported to work as expected by @Piciok in #8096 (comment)

Known issues with pull request:

None

Change log entry:

michaelDCurran added a commit that referenced this pull request Apr 6, 2018
@michaelDCurran michaelDCurran merged commit 4f21730 into nvaccess:master Apr 20, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.2 milestone Apr 20, 2018
@LeonarddeR LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BabbageWork Pull requests filed on behalf of Babbage B.V.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The gesture mappings for the Hims Braille Edge follow the global setting and not the model-specific map

3 participants