Expose available UIA patterns in developer info#7992
Merged
Conversation
added 2 commits
February 12, 2018 12:10
…to cache a property that is not supported on a particular version of Windows
josephsl
reviewed
Feb 12, 2018
| cacheRequest.addProperty(ID) | ||
| except COMError: | ||
| log.debug("Couldn't add property ID %d to cache request, most likely unsupported on this version of Windows"%ID) | ||
| continue |
Contributor
There was a problem hiding this comment.
I think you can remove this line, as after catching this exception, the for loop will continue anyway. Thanks.
josephsl
approved these changes
Feb 13, 2018
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Hi,
Looks fine to me (at least). Thanks for addressing review actions.
feerrenrut
approved these changes
Feb 14, 2018
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Could you please add some example output to the description of this PR. Otherwise this looks good.
Collaborator
Author
|
Edited the description as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #5712
Summary of the issue:
As @dave090679, it would be helpful to have available UIA patterns in the developer info for easier inspection of available UIA patterns.
Description of how this pull request fixes the issue:
This is based on @dave090679's proposal, but it also does some things a bit different.
Testing performed:
Tested fetching developer info on Windows 10 X64 and in a Win7x86 vm. See also the discussion with @josephsl in #5712. Concerns regarding compatibility with older versions of Windows 10 should be taken care of.
Known issues with pull request:
None
Example output
Change log entry: