Stop labels for checkboxes / radioButtons from being reported twice when tabbing / quicknavving in browse Mode, for Chrome / Firefox.#7988
Merged
Conversation
feerrenrut
approved these changes
Feb 14, 2018
|
Should this issue (and #7960) be fixed in version 2018.1? It still repeats in Chrome and Firefox, Windows 7 and Windows 10. |
Member
Author
|
@pcmarchal: This missed out on 2018.1 but will be in 2018.2. I have changed the milestone to reflect this. This was my mistake. |
amoshydra
added a commit
to amoshydra/nvda
that referenced
this pull request
Jan 24, 2026
… twice when tabbing / quicknavving in browse Mode, for Chrome / Firefox. nvaccess#7988 This commit revert 782330c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7960
Summary of the issue:
When tabbing or quickNaving to checkboxes or radio buttons in Firefox and Chrome in Browse mode, NVDA may report the label twice. Once as a symantic label, and once as the content.
This was caused by unneeded code in PR #7513.
that PR stopped treeting checkboxes and radio buttons has having name from content, no matter if their label was visible or not. This was probably to work around a previous bug in Chrome, but is certainly not needed now for that pr or any other checkboxes / radio buttons I can find.
Description of how this pull request fixes the issue:
This PR simply puts back the line that classes checkboxes and radio buttons as name is content in the Gecko vbufBackend.
Testing performed:
I ran through the tests in Chrome and Firefox provided on pr #7513, and most importantly the testcase provided in issue #7860. Double reporting no longer occurs, and the added cutnionality in PR #7513 still works as expected.
Known issues with pull request:
None
Change log entry:
Bug Fixes: