Allow setting good UIA windows in core or per appModule#7980
Merged
Conversation
feerrenrut
reviewed
Feb 14, 2018
|
|
||
| def isGoodUIAWindow(self,hwnd): | ||
| """ | ||
| returns true if the UIA implementation of the given window must be used, regardless whether native or not. |
Contributor
There was a problem hiding this comment.
Perhaps add a comment here and on isBadUIAWindow: "if isGoodUIAWindow and isBadUIAWindow return False, then the decision of whether to use UIA is left to the core."
What if they both return True?
Collaborator
Author
There was a problem hiding this comment.
What if they both return True?
isGoodUIAWindow will take precedence as UIAHandler.handler._isUIAWindowHelper will return early in that case. This is intentional, as whether good or bad, I think that the core should always have precedence over app Modules. On the other hand, appModules might want to override core behaviour for SysListView32 cases with native UIA implementations. The only case that is not covered is when the core decides good and an appModule decides bad.
feerrenrut
approved these changes
Feb 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #7961
Summary of the issue:
It is currently possible to implement
isBadUIAWindowon the appModule level to use IAccessible for windows that are reported as native UIA. The opposite is not yet offered.Description of how this pull request fixes the issue:
This allows appModule writers to implement
isGoodUIAWindow. If this returnsTrue, UIA is always used, regardless whether UIA is implemented natively or the MSAA proxy is active.There is now also a
goodUIAWindowClassNameslist on_UIAHandler, which is used for WDAG.Testing performed:
Tested this in Notepad, all MSAA objects instantly changed into UIA objects.
Known issues with pull request:
Change log entry: