Change status column of addons to enabled or disabled#7930
Conversation
feerrenrut
left a comment
There was a problem hiding this comment.
Great! Before I incubate this can you confirm that you have checked for any required changes in the user guide?
|
@feerrenrut, the user guide has been updated |
|
Hi, I think this PR should be reconsidered, as the status should display what’s actually happening right now as opposed to what will happen later. I advise looking at issue #3090 before proceeding, as I and others brought up this exact concern in 2016 when I worked on it. Thanks.
|
|
@josephsl commented on 22 Jan 2018, 16:50 CET:
I belief the only thing changed by this pr is running to enabled and suspended to disabled. When you enable a disabled add-on, the status will still show enable instead of enabled. May be we should rename these to enable/disable after restart to make clear what the distinction is between enable/enabled and disable/disaled? |
|
At the moment I dont think there is a clear distinction is between what running / enabled and suspended / disabled mean. If I understand this and #3090 correctly and with the following assumptions:
Using the term "globally disabled" to refer to the user having restarted NVDA with addons disabled. Then there are the following states for addons:
I recommend the following state texts:
The buttons should always say "Enable" and "Disable", these buttons should always be available, regardless of whether addons are globally disabled. |
|
It seems one of my assumptions in my previous comment was wrong. NVDA does need to be restarted to enable the addon. I will edit the comment to that effect. |
|
@feerrenrut, I agree with you, and have made the changes you suggested. |
| To disable an add-on, press the disable button. | ||
| To enable a previously disabled add-on, press the enable button. | ||
| You can disable an add-on if the add-on status indicates it is running or enabled, or enable it if the add-on is suspended or disabled. | ||
| You can disable an add-on if the add-on status indicates it is enabled, or enable it if the add-on is disabled. |
There was a problem hiding this comment.
For consistency with other lines in the user guide perhaps use quotes around enabled / disabled. Elsewhere it is seems to say "a status of". I don't think that this needs to be consistent with that.
Also could you add a note that when all addons are disabled via "restart with addons disabled" the status will show "enabled after restart"
Link to issue number:
Fixes #7929
Summary of the issue:
Currently, in the add-on manager, the line with information for each add-on reports whether the add-on is "running" or "suspended".
This PR provides consistencies between the disable and enable buttons and the text that is presented in the "status" column in the addons dialog.
Description of how this pull request fixes the issue:
Changed the text "running" and "suspended" to "enabled" and "disabled".
Testing performed:
Running NVDA from source with an addon installed and enabled and disabled the addon. Noticed that the status column changes to appropriate text.
Known issues with pull request:
None
Change log entry:
• Changes
The status column in the addons manager has been changed to indicate if the addon is enabled or disabled instead of running or suspended.