Report row and column span for table cells in speech and braille#7872
Conversation
|
Suggested change to |
|
It would be good to implement columnSpan / rowSpan NVDAObject properties for IAccessible NVDAObject and UIA NVDAObject, so that row and column spans are announced outside of documents. I can take a look at this at some point if you're not sure where to start. |
|
Actually, I'm required by another contract to support row / col span for IAccessible2. I'll add this support on top of this branch. |
|
@michaelDCurran commented on 26 Jan 2018, 02:00 CET:
This is already there for UIA, it has just not been used.
In that case, I'll leave this branch alone until further notice. Note that it might be good to think about a generic way to present row and column span when there is cellCoordsText (i.e. when a cell in Google Sheets is merged). In Excel, cellCoordsText is actually always empty, it seems. |
michaelDCurran
left a comment
There was a problem hiding this comment.
I just pushed support for IAccessible2 row/column span.
LeonarddeR
left a comment
There was a problem hiding this comment.
Your two last commits look ok, thanks a lot. You could consider changing the Copyright headers while at it.
|
@michaelDCurran: Have you actually tested this IAccessible2 code somewhere it can be easily confirmed to work? LibreOffice, for example? |
|
It has been tested on Amazon Kindle for PC with table support, not yet
publically available... but I can now talk about it.
A separate PR specific to that work will be coming very soon.
|
…d arguments to fulfill a desire of checkpot which will otherwise throw warnings
|
The following html file can be used to test rowspan and colspan in Focus mode in Firefox. Open the page in Firefox, switch to focus mode and tab through the links. The table is a 3 by 3 grid of cells, each one containing a link. However, row 1 column 1 has a colspan of 2, and row 2 column 1 has a rowspan of 2. |
|
I've done some research on support row/columnspan in LibreOffice, but it looks like they don't implement IAccessibleTableCell. I'm afraid it is therefore impossible at the moment. |
Link to issue number:
Partial fix for #2642.
Summary of the issue:
When a table cell spans multiple rows and/or columns, this is currently not reported by NVDA by default, only in Microsoft Excel.
Description of how this pull request fixes the issue:
This pr reports row and column span with both speech and braille.
Examples
For a cell in row 1 and column 1, spanning two columns
For a cell in row 1 and column 1, spanning two rows
For a cell in row 1 and column 1, spanning two rows and two columns
The reason why the latter speech output differ from the former, is that, especially with faster speech rates, it feels a bit more clear to only have the word through once. However, this is open to a debate.
Testing performed:
Tested the following applications
Known issues with pull request:
This does not work for Word yet as noted in #2642. However, I'm pretty sure that this code will work out of the box for the UIA implementation of Word (#7849).
Change log entry: