Update comtypes package to 1.1.3#7831
Merged
Merged
Conversation
This will be necessary to handle events from SAPI 5 once we have speechRefactor, as one of the parameters is a decimal which is not supported by our existing (very outdated) version of comtypes . comtypes has now been added as a separate git submodule.
Contributor
|
Hi, also note that this should allow us to port to Python 3 easily, as comtypes 1.1.3 supports Python 3 as well (#7105). Thanks.
|
feerrenrut
approved these changes
Dec 6, 2017
Collaborator
|
May be mention the update to the newer comtypes in the changes for developers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The version of comtypes we currently use in NVDA (0.6.2) is extremely old. There have been quite a few fixes in later versions. Some of which speechRefactor depends on.
Description of how this pull request fixes the issue:
This pr contains the 2 commits cherry picked from speechRefactor which update comtypes to 1.1.3, including it as a git submodule.
The update of comtypes is separate enough from speechRefactor that it can be taken separately, plus although we don't believe this should cause many breaking changes, it is best that this is tested as early as possible. Also, once this is in Master, working on speechRefactor will become that little bit easier as comInterfaces won't have to be constantly removed and re-built.
Testing performed:
Ran NVDA. Switched to sapi5 synth. Opened and read a document in Microsoft Word.
Known issues with pull request:
Just a note that the old comtypes will eventually have to be removed from miscDeps.
Once this goes into master, we can remove comtypes, scons and probably the old Handytech braille driver from miscDeps all in one go to reduce overhead of miscDeps changes.
Change log entry:
None