Handle COMError when fetching table header cells in Word documents#7777
Merged
Conversation
LeonarddeR
reviewed
Nov 20, 2017
| tableRangesEqual=tableRange.isEqual(self._curHeaderCellTrackerTable.range) | ||
| except (COMError, AttributeError): | ||
| tableRangesEqual=False | ||
| if not self._curHeaderCellTrackerTable or not tableRangesEqual: |
Collaborator
There was a problem hiding this comment.
I belief the if not self._curHeaderCellTrackerTable will alreade be dealt with if the lines above raise an AttributeError. Honestly, I'd check for if not self._curHeaderCellTrackerTable before executing the try statement, which looks somewhat cleaner. I leave it up to you.
Contributor
Author
There was a problem hiding this comment.
You're right, the first part of this or statement is unneeded. I removed it and left the try/except intact. Removing the except AttributeError and solving this in an if statement would introduce another variable to hold state, or a level of nested if statements. I think having all the logic in a single try/except makes the code easier to read.
michaelDCurran
approved these changes
Nov 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #6827
Summary of the issue:
Sometimes there is a reference to a COM object in _curHeaderCellTrackerTable, but the object throws a COMError on accessing one of it's properties, such as range.
Especially in Outlook this problem occurs if an email containing a table has been opened and the user closes that email and opens another email containing tables.
The unhandled COMError prevented the user from reading the email/document.
Description of how this pull request fixes the issue:
Handle the COMError.
Testing performed:
Tested on Outlook 2016.
Known issues with pull request:
None.
Change log entry: