Implement a generic system for acknowledgement packet handling#7732
Merged
Conversation
added 2 commits
November 8, 2017 14:25
michaelDCurran
approved these changes
Dec 4, 2017
Collaborator
Author
|
@michaelDCurran: Is there a reason why this is approved and not incubating yet? Is there something missing? |
michaelDCurran
added a commit
that referenced
this pull request
Dec 10, 2017
michaelDCurran
added a commit
that referenced
this pull request
Dec 11, 2017
This was referenced Dec 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #7721.
Summary of the issue:
From #7721 (comment)
Description of how this pull request fixes the issue:
This pr implements ACK packet handling on the main BrailleDisplayDriver class itself, rather than specific for every braille display. Currently, only the Handy Tech driver makes use of this generic functionality. This functionality will also be used for the Eurobraille braille display driver (#7488).
Testing performed:
Tested using a Handy Tech Basic Braille, which has some issues with updating the display if ACK handling is disabled. Difference between ACK handling enabled and disabled is clearly noticeable. Also tested in my eurobraille-native branch. The ACK timer is properly reset in case of a missed ack, and a debug warning is logged.
Known issues with pull request:
None i'm aware of.
Change log entry: