Skip to content

Implement a generic system for acknowledgement packet handling#7732

Merged
michaelDCurran merged 4 commits into
nvaccess:masterfrom
BabbageCom:i7721
Jan 1, 2018
Merged

Implement a generic system for acknowledgement packet handling#7732
michaelDCurran merged 4 commits into
nvaccess:masterfrom
BabbageCom:i7721

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Closes #7721.

Summary of the issue:

From #7721 (comment)

For several braille displays, when sending a packet, the display acknowledges the receipt of a packet. This is a mechanism to make sure that a packet has been delivered to a braille display in a correct way. Several displays have such a feature, including Handy Tech, Eurobraille and Freedom Scientific displays.

Description of how this pull request fixes the issue:

This pr implements ACK packet handling on the main BrailleDisplayDriver class itself, rather than specific for every braille display. Currently, only the Handy Tech driver makes use of this generic functionality. This functionality will also be used for the Eurobraille braille display driver (#7488).

Testing performed:

Tested using a Handy Tech Basic Braille, which has some issues with updating the display if ACK handling is disabled. Difference between ACK handling enabled and disabled is clearly noticeable. Also tested in my eurobraille-native branch. The ACK timer is properly reset in case of a missed ack, and a debug warning is logged.

Known issues with pull request:

None i'm aware of.

Change log entry:

@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

@michaelDCurran: Is there a reason why this is approved and not incubating yet? Is there something missing?

michaelDCurran added a commit that referenced this pull request Dec 10, 2017
michaelDCurran added a commit that referenced this pull request Dec 11, 2017
@michaelDCurran michaelDCurran merged commit 89d3dae into nvaccess:master Jan 1, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.1 milestone Jan 1, 2018
@LeonarddeR LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BabbageWork Pull requests filed on behalf of Babbage B.V. component/braille

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native braille display drivers: provide a generic way to handle acknowledgement packets.

3 participants