Native driver for Hims displays#7712
Merged
Merged
Conversation
added 10 commits
October 31, 2017 10:23
….Bulk class that facilitates bulk USB communication using separate end points for i/o.
…endencies from readme
Collaborator
Author
|
Note, I opened a pr for this to allow for easier tracking of progress. Though I consider this driver ready, I'd like feedback from Sync Braille users before this is ready for review. |
Collaborator
Author
|
I've received positive test results from a Sync Braille user and made some changes based on the feedback I've gotten. This is now ready for a review. |
This was referenced Nov 6, 2017
michaelDCurran
approved these changes
Nov 23, 2017
Member
|
Can hansoneConnect.dll be removed now that this pr is merged? Happy to do it, but just checking. |
Collaborator
Author
|
Yes, as well as de dll for sync braille.
… Op 20 apr. 2018 om 06:54 heeft Michael Curran ***@***.***> het volgende geschreven:
Can hansoneConnect.dll be removed now that this pr is merged? Happy to do it, but just checking.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This driver has been written by @BabbageCom with the consent of Hims.
Try build
Link to issue number:
Closes #7459.
Fixes #7679.
Closes #6063
Fixes #6086.
Fixes #3157.
fixes #7837.
Summary of the issue:
The current Hims and syncBraille drivers currently require a vendor library and aren't thread safe. Furthermore, other prerequisites (such as disabling the driver when a write error occurs) aren't met by these drivers.
Description of how this pull request fixes the issue:
This:
In comparison with the earlier Hims driver, this remaps the scroll keys for devices with multiple scroll keys to follow the conventions of the internal functionality and other screen readers. Furthermore, the keys that were known as advance keys earlier are now named f keys, since this is how Hims names them.
Testing performed:
Tested the following devices:
I've also tested a Braille Edge, a Braille Sense u2 Qwerty and a Braille Sense u2 Perkins with earlier iterations of this driver.
Known issues with pull request:
Change log entry:
Changes
Bug fixes
Changes for developers