Ensure NVDA updates succeed with Controlled folder Access enabled#7697
Merged
Conversation
…n't exist before, or some of the properties were different.
Contributor
|
Hi, suggestion: could you add that this is for Windows 10 Fall Creators update? Thanks.
|
Collaborator
|
I'd like to suggest either one of the following:
|
Member
Author
|
Number 1 would not help as Controlled Folder Access protects both
Desktop directories as far as I am aware.
Number 2 is possible, but would be not trivial as nvda_slave will need
to convey the warning back to the main NVDA some how.
I'm not willing to do this part for 2017.4 as we've had enough installer
trouble.
|
Collaborator
|
@michaelDCurran commented on 26 okt. 2017 08:05 CEST:
Very well said. |
|
Since I really do not understand this, not running the latest version of
win10, I guess the only thing you can do is advise people not to have this
function on when installing.
Far too much fiddling going on at the moment.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
-----
|
feerrenrut
approved these changes
Oct 31, 2017
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Might be worth adding a comment pointing to the issue number saying something to the effect of "Only try to create/modify the shortcut if it is missing or the details are incorrect."
feerrenrut
approved these changes
Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7696
Summary of the issue:
NVDA installs fail if Windows 10's Controlled Folder Access is enabled as NVDA is unable to create the desktop shortcut.
Description of how this pull request fixes the issue:
The interactive NVDA install has always asked the user if it should create a desktop shortcut (if no previous install was detected), or to keep the existing desktop shortcut (if a previous install was detected). However, if the user had chosen to keep the existing shortcut, NVDA would still update / re-save the desktop shortcut (but keeping the shortcut key in tact).
this PR now changes installer.createShortcut so that a shortcut is only physically saved to disc if it does not already exist, or one or more of its properties differ from what the new NVDA install requires.
this means that if the user updates NVDA via NVDA's update feature, or installs via the launcher and chooses to keep the existing Desktop shortcut, the install will now succeed, even if controlled folder access is enabled.
Testing performed:
Installed NVDA on Windows 10, with and with out Controlled folder Access, and with and with out an existing desktop shortcut.
Known issues with pull request:
The install will still fail if the user installs NVDA for the first time, and chooses to create the desktop shortcut. The user can avoid the failiour by unchecking the box, if they are unwilling to disable Controlled Folder Access.
Change log entry:
Bug fixes: