Update Spotify app module to support recent versions of Spotify.#7689
Merged
Conversation
1. Spotify no longer fires focus on objects that die before we can fetch them, so remove the hack which worked around this. 2. Spotify still fires focus on an ancestor window instead of the correct focus. However, the trick we previously used to get the correct focus no longer works. Switch to a new trick which does work.
LeonarddeR
approved these changes
Oct 24, 2017
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
This bug annoys me in a major way :)
I assume using a FocusableUnfocusableContainer here doesn't do the job?
Contributor
Author
|
No:
1. FocusableUnfocusableContainer just overrides setFocus. It doesn't change
the behaviour when a focus event hits that control. This makes sense, since
that would by definition mean the container was focusable, not unfocusable.
:)
2. Even if it did bounce focus events, it searches recursively for the
first focusable node. We want the node that actually has focus. Thankfully,
Chromium can answer this question via accFocus (which NVDA exposes via
activeChild).
|
…fore we can fetch them. This happens far less than it does before, but it does still happen in some cases. For example, it happens when pressing enter on an artist in search results.
Contributor
Author
|
I just reinstated the hack working around focus objects which die before we can fetch them. This happens far less than it does before, but it does still happen in some cases. For example, it happens when pressing enter on an artist in search results. I'm updating the initial comment accordingly. |
feerrenrut
approved these changes
Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Spotify doesn't fire focus on the correct object when it comes to the foreground (e.g. after alt+tab). I fixed this for an older version of Spotify in #5439, but this is broken in the current version of Spotify.
Description of how this pull request fixes the issue:
Spotify fires focus on an ancestor window instead of the correct focus. However, the trick we previously used to get the correct focus no longer works. Switch to a new trick which does work.
Testing performed:
Tested with Spotify 1.0.66.478.g1296534d:
Known issues with pull request:
None known.
Change log entry:
In Bug Fixes: