Skip to content

Change excelerator for regular expression#7656

Merged
feerrenrut merged 1 commit into
nvaccess:masterfrom
ehollig:I6782
Oct 31, 2017
Merged

Change excelerator for regular expression#7656
feerrenrut merged 1 commit into
nvaccess:masterfrom
ehollig:I6782

Conversation

@ehollig

@ehollig ehollig commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #6782

Summary of the issue:

Now there is a clash between the Replacement field and the regular expression radio button after pressing the add or edit button in the dictionary dialog.

Description of how this pull request fixes the issue:

Change the hotkey for the "Regular expression" radio button in the dictionary dialog from R to E to prevent clashes with the "Replacement" edit field.

Testing performed:

Opened the default dictionary and verified the hotkey changed when adding a new entry and editing an existing entry.

Known issues with pull request:

None

Change log entry:

• Changes: The hotkey for the Regular expression radio button in the dictionary dialog is changed from alt+r to alt+e (#6782)

@ehollig ehollig requested a review from feerrenrut October 12, 2017 14:25
feerrenrut added a commit that referenced this pull request Oct 16, 2017
Merge remote-tracking branch 'origin/pr/7656' into next
@feerrenrut feerrenrut merged commit 9731a72 into nvaccess:master Oct 31, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Oct 31, 2017
feerrenrut added a commit that referenced this pull request Oct 31, 2017
The hotkey for the regular expression radio button in the dictionary
dialog is changed from alt+r to alt+e (issue #6782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regular expression hotkey conflict in add dictionary entry dialog

4 participants