Enhance add-on installation messages to display version information#7542
Conversation
|
CC @derekriemer, @nvdaes and others for further thoughts please.
Edit: Removed quoted email.
|
| return | ||
| summary=bundle.manifest["summary"] | ||
| curVersion=prevAddon.manifest["version"] | ||
| newVersion=bundle.manifest["version"] |
There was a problem hiding this comment.
Are we guaranteed that both the old and new addon will have a manifest version parameter? If not what would happen?
There was a problem hiding this comment.
It wasn't yet possible to install add-ons without a version, and this is not handled gracefully (i.e. an error is raised in the log and there is no visible error). Theoretically, this code indeed would raise an error if the old add-on doesn't have a version in its manifest, but it shouldn't have been possible to install it before.
Having said that, I think it would be good to have a visible error raised if either the old or the new manifest is broken.
There was a problem hiding this comment.
Is the error for a broken manifest something that you intend to resolve in this PR? I would suggest not.
There was a problem hiding this comment.
Nope, I"m not intending to do this as it is only partially related to this pr.
Link to issue number:
fixes #5324
Summary of the issue:
When updating add-ons, it is not yet clear from which version to which version you're updating.
Description of how this pull request fixes the issue:
Testing performed:
Updated add-ons to newer and same versions, the messages did show up as expected.
Known issues with pull request:
None I'm aware of
Credits
Many thanks to @beqabeqa473 for the initial work.