speech.speakTextInfo: only announce exiting old controlFields if the reason is not reason_focus.#7434
Merged
Conversation
…reason is not reason_focus. This ensures that quicknav / tabbing etc does not announce many exit messages when jumping to an arbitrary part of the page.
jcsteh
approved these changes
Jul 31, 2017
jcsteh
left a comment
Contributor
There was a problem hiding this comment.
Nice. I think checking for != REASON_FOCUS is acceptable, as this makes tabbing more consistent with focus mode.
| endingBlock=bool(int(controlFieldStackCache[count].get('isBlock',0))) | ||
| if endingBlock: | ||
| speechSequence.append(SpeakWithoutPausesBreakCommand()) | ||
| # #2591: If the reason is not focus, Speak the exit of any controlFields not in the new stack. |
Contributor
There was a problem hiding this comment.
It'd be good to have a comment here explaining why we don't do this for focus in practical terms; e.g. We don't do this for focus because hearing "out of list", etc. isn't useful when tabbing or using quick navigation and makes navigation less efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #2591
Description of how this pull request fixes the issue:
This ensures that quicknav / tabbing etc does not announce many exit messages when jumping to an arbitrary part of a web page.
Testing performed:
Wikipedia article:
Known issues with pull request:
Change log entry:
Section: Changes