Add more default task switching gestures to freedom scientific braille displays#7387
Conversation
…hift tab as well as windows tab
|
cc @bramd |
|
@Oliver2213 I don't see a problem in adding these, however I've two questions:
|
|
I didn't think of adding them to the users guide, I'll certainly do that soon. As for how I came up with them... The command for alt+tab is space with dots 2-3-4-5, which is "t" in Braille; dots 1-2-5-6 are the reverse of that, which makes sense for alt+tab. The command for windows+tab is the "s" in Braille (which stands for switching, as in task switching); it's also nearly the same as the default alt_tab command, just take out dot 5. |
|
We already have lots of different key assignments for each braille
display. Defining a standard list of such gestures will solve that in
the future. For now, this is fine with me if it's documented in the user
guide as well.
|
LeonarddeR
left a comment
There was a problem hiding this comment.
Feel free to update the copyright line
|
Congrats on your first incubating PR!! |
LeonarddeR
left a comment
There was a problem hiding this comment.
Thanks to @derekriemer for reporting this privately.
| "kb:alt" : ("br(freedomScientific):dot1+dot3+dot4+brailleSpaceBar",), | ||
| "kb:alt+tab" : ("br(freedomScientific):dot2+dot3+dot4+dot5+brailleSpaceBar",), | ||
| "kb:alt+shift+tab" : ("br(freedomScientific):dot1+dot2+dot5+dot6+brailleSpaceBar",), | ||
| "kb:win+tab" : ("br(freedomScientific):dot2+dot3+dot4+brailleSpaceBar",), |
There was a problem hiding this comment.
This one is wrong and breaks the driver currently. it should be windows, not win.
@Oliver2213: Could you provide a pr that fixes this?
|
Sure, thanks for letting me know. |
Summary: The Freedom Scientific braille display driver only provides a gesture for alt+tab by default.
Fixes: this pr adds gestures for alt shift tab (dots 1-2-5-6 with space), and windows tab (dots 2-3-4 with space).
Suggested what's new entry (section 'changes'): Add default gestures for alt shift tab and windows tab with all supported Freedom Scientific braille displays.