Pressing Enter to close Start menu in Windows 10 no longer results in NVDA announcing search field text. re #7370.#7375
Merged
Conversation
…tart menu) is closing. re nvaccess#7370. due to use of announceNewlineText, when start menu closes and when Enter is pressed, search field value will be announced, which sometimes leads to side effects such as core freeze. Address this through initOverClass in UIA.SearchField that turns this flag off if and only if we're in start menu in Windows 10.
derekriemer
reviewed
Jul 11, 2017
|
|
||
| def initOverlayClass(self): | ||
| # #7370: do not announce text when start menu (searchui) closes. | ||
| self.announceNewLineText = self.appModule.appName != "searchui" |
Collaborator
There was a problem hiding this comment.
Would creating a new overlay just for this be better?
michaelDCurran
requested changes
Jul 11, 2017
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
I agree with Derek. Either make this into its own overlay class in searchUI, or perhaps even just place this variable on the SearchField class no matter if it is searchUI or not. For now at least, this class is only used for single-line edit fields where speaking on enter makes no sense. Obviously I do acknowledge that in the future this may change.
Contributor
Author
|
Hi, when I set announceNewlineText inside SearchField class, it returns True even though I said False, yet the app module method works. Modification on the way.
From: Michael Curran [mailto:notifications@github.com]
Sent: Monday, July 10, 2017 11:16 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Pressing Enter to close Start menu in Windows 10 no longer results in NVDA announcing search field text. re #7370. (#7375)
@michaelDCurran requested changes on this pull request.
I agree with Derek. Either make this into its own overlay class in searchUI, or perhaps even just place this variable on the SearchField class no matter if it is searchUI or not. For now at least, this class is only used for single-line edit fields where speaking on enter makes no sense. Obviously I do acknowledge that in the future this may change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#7375 (review)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkGp82D7_yBa5NijKxufZ5tppoiuKks5sMxM0gaJpZM4OTrW3> .
|
…at disables announcement of newline text. re nvaccess#7370. Reviewed by Mick Curran (NV Access): better to create an overlay class for this just for searchui. This also allows easy modifications in the future if the need arises.
michaelDCurran
approved these changes
Jul 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following:
Suggested what's new entry:
section: bug fixes
In start menu in Windows 10, pressing Enter to close the start menu after a search no longer causes NVDA to announce search text.
Thanks.