Change the default braille table to Unified English Braille Code grade 1#7365
Merged
Conversation
|
Although I do not use a tactile display myself. many of us still disagree
with UEB as a standard for various reasons I'll not go into here. Just
saying.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "James Teh" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Friday, July 07, 2017 7:22 AM
Subject: [nvaccess/nvda] Change the default braille table to Unified English
Braille Code grade 1 (#7365)
… ### Link to issue number:
Fixes #6952.
### Summary of the issue:
While well known by users who have used computers with braille in the
past, English U.S. computer braille is not well known by braille users in
general; e.g. putting numbers in lower cells. Now that Unified English
Braille has become standard in major English speaking countries, it seems
to be the most suitable as a default choice.
### Description of how this pull request fixes the issue:
Changes the default table in the config spec.
### Testing performed:
Tested that the table is chosen when no table is set in the config.
### Known issues with pull request:
Does not account for other languages, but this is not new and should be
dealt with separately. See #290.
### Change log entry:
Changes:
```
- The default braille table is now Unified English Braille Code grade 1.
(#6952)
```
You can view, comment on, or merge this pull request online at:
#7365
-- Commit Summary --
* Change the default braille table to Unified English Braille Code grade
1. (#6952)
-- File Changes --
M source/config/configSpec.py (4)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/7365.patch
https://github.com/nvaccess/nvda/pull/7365.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#7365
|
Contributor
|
Yes, but it is the standard now. Nothing is stopping you from switching
back to the old one as soon as you install.
|
feerrenrut
approved these changes
Jul 10, 2017
Collaborator
|
Have you considered the fact that a checked checkbox now looks like ⠐⠣⠭⠐⠜ by default? I agree that UEB should be the default, but if this goes into master for 2017.3 and #7188 will arrive in 2017.4, it will mean that the default braille look for check boxes will change two releases in a row. CC @dkager |
Contributor
Author
|
That's a fair point. However, given that the check box indicators currently
change for every table, I think it's okay; they are currently characters,
rather than patterns.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #6952.
Summary of the issue:
While well known by users who have used computers with braille in the past, English U.S. computer braille is not well known by braille users in general; e.g. putting numbers in lower cells. Now that Unified English Braille has become standard in major English speaking countries, it seems to be the most suitable as a default choice.
Description of how this pull request fixes the issue:
Changes the default table in the config spec.
Testing performed:
Tested that the table is chosen when no table is set in the config.
Known issues with pull request:
Does not account for other languages, but this is not new and should be dealt with separately. See #290.
Change log entry:
Changes: