New braille translation tables#7364
Conversation
|
Also added Persian tables requested in #7367. Updating description accordingly. |
| addTable("en-us-comp8.ctb", _("English (U.S.) 8 dot computer braille")) | ||
| # Translators: The name of a braille table displayed in the | ||
| # braille settings dialog. | ||
| addTable("en-us-comp8-ext.utb", _("English (U.S.) 8 dot extended computer braille")) |
There was a problem hiding this comment.
I wonder if we can (and want to) drop en-us-comp8.ctb now:
- Because it is a subset of the 'extended' table. The only reason not to do this is that users prefer the hexadecimal codes over some dot patterns they may not be familiar with. However, I think this is unlikely since most dot patterns match those in other major screen readers for Windows.
- Because it is a bit confusing which table does what.
Arguably I should bring this up with the liblouis team, but nothing will happen on that front before NVDA 2017.3.
|
I think that's pretty fair reasoning. Were you thinking we'd drop the "extended" suffix from the description or keep it and just drop the existing? On one hand, keeping extended is potentially confusing if we drop the other table because there's an extended table but no table that doesn't say extended. On the other hand, dropping extended might lead one to think the table closely follows the standard when it is in fact a superset. Personally, I'd vote for dropping the extended suffix.
As to whether doing this is possible, we could just add it as a rename now that NVDA supports this thanks to @josephsl. So, we would drop the old table, map it in the renames map and then anyone on the old table would get transitioned automatically.
|
I agree. For example, JAWS also speaks about "computer braille" without mentioning that it goes much beyond standards. SuperNova is even more lax with table names. That's not to say that NVDA should follow, but I agree the argument about confusing table names weighs heavier. |
… braille table, use that table to replace the existing English (U.S.) 8 dot computer braille table. Re #6836.
|
The extended computer braille table now replaces the existing computer braille table. Rationale as per #7364 (comment). I'm updating the PR description accordingly. @feerrenrut, would you mind reviewing the last commit please? |
|
See also #7407. |
|
Forgot to mention yesterday that this PR already includes Danish 8-dot computer braille, but not "grade 1.5". I am definitely not the one to say if these additional two tables are useful enough to include, hence the separate PR for discussion. |
Link to issue number:
Fixes #6188. Fixes #6550. Fixes #6836. Fixes #7367. Re #6773.
Summary of the issue:
Users have requested that several braille translation tables be available for selection in NVDA. They are already included in liblouis.
Description of how this pull request fixes the issue:
Testing performed:
I checked that the files load, but I don't know these braille codes, so I can't do much testing beyond that.
Known issues with pull request:
None.
Change log entry:
New Features: