Fix spurious reporting of aria-hidden focus ancestors in Firefox.#7357
Merged
Conversation
When presentationType is unavailable, isPresentableFocusAncestor should be False, just as it is for layout. Previously, it was True. Unfortunately, NVDA's message dialogs are sometimes briefly treated as unavailable when they get focus. We still want them to be reported. Work around this in the app module for NVDA itself.
michaelDCurran
approved these changes
Jul 5, 2017
|
Had these changes been done in the release build that is available on https://www.nvaccess.org/download/ ? |
|
Where can we find updated version of nvda with fix of this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #5741.
Summary of the issue:
If an author (incorrectly) focuses something inside an aria-hidden element in Firefox, NVDA will report all of the aria-hidden ancestors, even if they would have been layout otherwise.
Description of how this pull request fixes the issue:
When presentationType is unavailable, isPresentableFocusAncestor should be False, just as it is for layout. Previously, it was True.
Unfortunately, NVDA's message dialogs are sometimes briefly treated as unavailable when they get focus. We still want them to be reported. Work around this in the app module for NVDA itself.
Testing performed:
Known issues with pull request:
None.
Change log entry:
In Bug Fixes: