Include application, dialog elements and audio and video tags for embedded object navigation in browse mode#7290
Merged
Conversation
added 3 commits
June 14, 2017 19:09
…objects now includes audio and video tags, dialogs and applications
…is now supported for objects with the Pane UIA Control Type and either the application, alertdialog or dialog aria role
dkager
suggested changes
Jun 22, 2017
|
|
||
| ++ Embedded Objects ++ | ||
| Pages can include rich content using technologies such as Adobe Flash and Sun Java, as well as applications and dialogs. | ||
| Pages can include rich content using technologies such as Adobe Flash, Oracle Java and HTMl5, as well as applications and dialogs. |
| Where these are encountered in browse mode, NVDA will report "embedded object", "application" or "dialog", respectively. | ||
| You can press enter on these objects to interact with them. | ||
| You can quickly move to them using the o and shift+o embedded object single letter navigation keys. | ||
| to interact with these objects, you can press enter on them. |
Contributor
There was a problem hiding this comment.
Missing capital at the beginning of the sentence.
Collaborator
Author
|
@dkager: I assume you are ok with the current state of this branch? |
dkager
approved these changes
Jul 12, 2017
This was referenced Jul 18, 2017
michaelDCurran
approved these changes
Jul 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #7239
Summary of the issue:
Embedded objects based on the html object tag are getting more rare these days, while we see increasing occurrence of applications, dialogs and audio and video tags inside web pages.
Description of how this pull request fixes the issue:
This adds applications and dialogs as well as audio/video tags for Internet Explorer, Firefox and Chrome. For Edge, I was unable to cover audio/video tags (see below)
Testing performed:
I tried navigating http://www.mediaelementjs.com/ with o using all the browsers above. I also created a test html document with alertdialog, dialog and application roles, which also navigated fine.
Known issues with pull request:
In Edge, audio and video tags are regarded to as embedded object. Technically, they have the group UIA control type. In NVDAObjects.uia.edge.EdgeTextInfo._getControlFieldForObject, groupings are made to report as embedded object in certain situations, but I have not yet found a reliable way to throw the required information to do this reliably in a UIA Multi Property Condition.
Change log entry: