Latest espeak to resolve italian pronunciation#7115
Closed
feerrenrut wants to merge 8 commits into
Closed
Conversation
This is to see if it resolves issues with pronunciation in Italian
zhy has been excluded as it wont compile.
michaelDCurran
approved these changes
May 3, 2017
Contributor
|
This update introduces some ugly regressions. According to espeak-ng/espeak-ng#250, at least some of these should be fixed in the latest espeak-ng commit. However, @derekriemer noted on Gitter that he can't get this commit to build with NVDA:
@derekriemer also did a bisect and discovered that this occurs in the very first espeak-ng commit after the one we now use in next. @feerrenrut, can you take a look at updating this PR to the latest espeak-ng commit? Thanks. |
Update to commit eb3c9a9bbd186ec3ead40059fbe865eed1cd3772 of Espeak-ng See https://github.com/espeak-ng/espeak-ng/commits/eb3c9a9bbd186ec3ead40059fbe865eed1cd3772
michaelDCurran
approved these changes
May 9, 2017
|
This may well be totally unrelated to this as its an English issue, but.
When the
% symbol is spoken it obeys the symbol pronunciation in the list if its
actually the normal
% in a text string or static on a page, However when spoken as a progress
bar, it changes slightly. Though not a big issue it seems that the way this
is spoken has recently changed in Espeak and thus you hear the two versions
one affected by the symbols list and one not.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
-----
|
feerrenrut
added a commit
that referenced
this pull request
May 11, 2017
feerrenrut
added a commit
that referenced
this pull request
May 16, 2017
Fixes part of #7167 selecting Norwegian Bokmål no longer causes an error.
jcsteh
approved these changes
May 26, 2017
| voices=OrderedDict() | ||
| for v in _espeak.getVoiceList(): | ||
| l=v.languages[1:] | ||
| # #7167: Some languages names require unicode characters EG: Norwegian Bokmål |
Contributor
There was a problem hiding this comment.
nit: I think this would be more readable as "Some language names contain Unicode characters".
Clarified comment
feerrenrut
added a commit
that referenced
this pull request
May 26, 2017
To commit c5afdbe0d1292a6f1d95e3794b62e4be93d7a6cd
feerrenrut
added a commit
that referenced
this pull request
May 26, 2017
feerrenrut
added a commit
that referenced
this pull request
Jun 13, 2017
This commit will revert 8 updates to espeak that have been incubated to the 'next' branch, see #7115 Revert "Update espeak-ng" commit 362af4a. Revert "Review actions for #7115" commit b81d541. Revert "Allow unicode characters in espeak language names" commit b2b1ca5. Revert "Update espeak to fix #7167" commit 8fa4335. Revert "Fix build errors with latest espeak." commit 6e005f8. Revert "Update to the latest espeak" commit 36a381d. Revert "Get espeak building again" commit a184415. Revert "Update espeak-ng" commit 22e2931.
Contributor
Author
|
The changes for this PR are going to be reverted from 'next'. We will first incubate the most recent release of espeak-ng 1.49.1. Once that is incubated and (if considered stable) merged to master, we will resume updating next on a regular basis. For now I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Espeak to commit 5226ff0
Some changes had to be made to build system so support this Espeak update.
We must now compile and link and include in the search paths
ucd-tools. To do this, I diffed the the visual studio project files in the espeak project.I have excluded 'zhy` dictionary since it was failing to build.
A try build has been given to the user asking for better support, we have not yet had feedback.