Skip to content

Speech: moreve reason_* constants#6878

Merged
feerrenrut merged 1 commit into
nvaccess:masterfrom
josephsl:i6846-removeSpeechReasonConstants
Apr 4, 2017
Merged

Speech: moreve reason_* constants#6878
feerrenrut merged 1 commit into
nvaccess:masterfrom
josephsl:i6846-removeSpeechReasonConstants

Conversation

@josephsl

Copy link
Copy Markdown
Contributor

Resolves the following:

Thanks.

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems safe to remove based on the information in #6846 (comment)

feerrenrut added a commit that referenced this pull request Mar 18, 2017
Re Issue #6846
Merge branch 'josephsl-i6846-removeSpeechReasonConstants' into next
@feerrenrut feerrenrut merged commit af4f4fa into nvaccess:master Apr 4, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.2 milestone Apr 4, 2017
feerrenrut added a commit that referenced this pull request Apr 4, 2017
- Deprecated code removed:
 - PR #6878: `speech.REASON_*` constants, `controlTypes.REASON_*` should be used
   instead. (issue #6846)
 - PR #6877: `i18nName` for synth settings, `displayName` and
   `displayNameWithAccelerator` should be used instead. (issues #6846, #5185)
 - PR #6876: `config.validateConfig`. (issues #6846, #667)
 - PR #6875: `config.save`. (issue #6846)

- PR #6914: Support Windows Calculator on Windows 10 Enterprise LTSB (Long-Term
  Servicing Branch) and Server. (issue #6914)
- PR #6987: Reduced the chance of configuration file being corrupted when
  Windows shuts down. Configuration files are now written to a temporary
  file before replacing the actual configuration file. (issue #3165)
@josephsl josephsl deleted the i6846-removeSpeechReasonConstants branch July 19, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants