Update to pySerial 2.7.#6854
Merged
Merged
Conversation
This is needed to fix a UnicodeDecodeError in some languages when opening a serial port fails. This was preventing braille display drivers from trying further ports which might have worked. pySerial is now included as its own git submodule, rather than as part of miscDeps. This necessitated adding its directory to the Python module search path in sourceEnv. Also, scons now sets the PYTHONPATH environment variable based on sourceEnv, rather than having the directories listed in two separate places.
feerrenrut
approved these changes
Feb 8, 2017
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Could you make a PR for the miscDeps changes? I think this will help to be able to see the status.
jcsteh
added a commit
that referenced
this pull request
Mar 15, 2017
jcsteh
added a commit
that referenced
this pull request
Mar 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to fix a UnicodeDecodeError in some languages when opening a serial port fails. This was preventing braille display drivers from trying further ports which might have worked.
pySerial is now included as its own git submodule, rather than as part of miscDeps. This necessitated adding its directory to the Python module search path in sourceEnv. Also, scons now sets the PYTHONPATH environment variable based on sourceEnv, rather than having the directories listed in two separate places.
Fixes #6845.