Fall back to Microsoft's own dynamic ducking, and disable our 'always ducking' mode, for Windows builds 14986 and up.#6799
Merged
Merged
Conversation
… ducking' mode, for Windows builds 14986 and up. As this is hopefully temporary, the quickfix solution is to force usage of our own 'always duck' mode, which allows microsoft to dynamic duck how ever it likes. Fixes #6684
jcsteh
approved these changes
Jan 27, 2017
jcsteh
left a comment
Contributor
There was a problem hiding this comment.
We still need to discuss the alternative implementation, but we'll accept this as the minimum, so I'm reviewing now.
| if mode<0 or mode>=len(audioDuckingModes): | ||
| raise ValueError("%s is not an audio ducking mode") | ||
| # Normalize mode to within the exceptable range of values | ||
| mode=max(min(mode,len(audioDuckingModes)-1),0) |
Contributor
There was a problem hiding this comment.
I assume you do this so that old configurations won't break if the user set it to always duck? A comment here would be nice as to why we normalise instead of throwing an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this is hopefully temporary, the quickfix solution is to force usage of our own 'always duck' mode, which allows microsoft to dynamic duck how ever it likes.
Fixes #6684