Add "No message timeout" braille setting#6777
Conversation
feerrenrut
left a comment
There was a problem hiding this comment.
Thanks, overall this looks really good. What happens when the there is a message currently being displayed "indefinitely" and the setting is changed to a timeout?
| self.messageTimeoutEdit.Disable() | ||
|
|
||
| # Translators: The label for a setting in braille settings to display a message on the braille display indefinitely. | ||
| noMessageTimeoutLabelText = _("No &message timeout") |
There was a problem hiding this comment.
Personally, I think the positive form of this label would be clearer, eg: "Show message indefinitely"
| min=int(config.conf.getConfigValidationParameter(["braille", "messageTimeout"], "min")), | ||
| max=int(config.conf.getConfigValidationParameter(["braille", "messageTimeout"], "max")), | ||
| initial=config.conf["braille"]["messageTimeout"]) | ||
| if self.noMessageTimeoutCheckBox.GetValue(): |
There was a problem hiding this comment.
This causes an exception, since self.noMessageTimeoutCheckBox is not created until line 1575
|
@feerrenrut Pushed some new stuff. |
|
I have had a look at this, the alignment of the controls looks good. Could you please talk about what kind of testing you have done on this? |
Tested this with one display (since the code isn't driver-specific).
Also tested this with an actual use case, reading messages in Skype without having to rush. |
- PR #7169 : Editable div elements in Chrome are no longer have their label reported as their value while in browse mode. (Issue #7153) - PR #6396 : An unbound gesture (script_restart) has been added to allow NVDA to be restarted quickly. (PR #6396) - PR #6777 : A Braille setting has been added to "show messages indefinitely". (Issue #6669) - PR #7133 : Pressing end while in browse mode of an empty Microsoft Word document no longer causes a runtime error. (Issue #7009) - PR #6868 : The keyboard layout can now be set from the NVDA Welcome dialog. (Issue #6863) - PR #6813 : The names of "landmarks" are abbreviated in Braille (Issue #3975)
In #6669 we discussed two corner cases for the braille message timeout:
In the end I decided to leave the original behavior alone: a message timeout of 0 disables messages altogether.
There is now an extra checkbox "No message timeout" to show messages indefinitely. It seemed most logical to add this checkbox after the edit field. Of course, enabling the checkbox disables the edit field.
This approach avoids having to add a config profile upgrade step and won't be confusing to users who currently have the timeout set to 0.